Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 926333004: Remove implicit config options from provision_devices (Closed)

Created:
5 years, 10 months ago by perezju
Modified:
5 years, 10 months ago
Reviewers:
klundberg, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove implicit config options from provision_devices Build bot recipes have been upgraded to explicitly request the provisioning options they need. At this point it should be safe to remove the code that guessed the required configuration from the bot name. BUG=450984 Committed: https://crrev.com/545a9ceb6ca0810e9ee4df8990071c18c3a066d7 Cr-Commit-Position: refs/heads/master@{#317034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -24 lines) Patch
M build/android/provision_devices.py View 3 chunks +6 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
perezju
5 years, 10 months ago (2015-02-18 10:47:33 UTC) #2
klundberg
LGTM but please submit at a time of day where you can make sure that ...
5 years, 10 months ago (2015-02-18 15:20:42 UTC) #3
jbudorick
On 2015/02/18 15:20:42, klundberg wrote: > LGTM but please submit at a time of day ...
5 years, 10 months ago (2015-02-18 16:18:46 UTC) #4
perezju
On 2015/02/18 16:18:46, jbudorick wrote: > On 2015/02/18 15:20:42, klundberg wrote: > > LGTM but ...
5 years, 10 months ago (2015-02-18 16:22:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926333004/1
5 years, 10 months ago (2015-02-19 10:10:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/3399)
5 years, 10 months ago (2015-02-19 12:04:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926333004/1
5 years, 10 months ago (2015-02-19 12:19:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 13:14:27 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 13:15:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/545a9ceb6ca0810e9ee4df8990071c18c3a066d7
Cr-Commit-Position: refs/heads/master@{#317034}

Powered by Google App Engine
This is Rietveld 408576698