Issue 926293004: Embed store callback in handler via weak cell.

Issue 926293004: Embed store callback in handler via weak cell. (Closed)

Created:
5 years, 10 months ago by ulan

Modified:
5 years, 10 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Embed store callback in handler via weak cell. BUG=chromium:454619 LOG=NO Committed: https://crrev.com/e12367827c1c29d407a7eee447d17d3ccb1809ef Cr-Commit-Position: refs/heads/master@{#26748}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -21 lines)			Patch
M	src/ic/arm/handler-compiler-arm.cc	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download
M	src/ic/arm64/handler-compiler-arm64.cc	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/ic/handler-compiler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic/ia32/handler-compiler-ia32.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/ic/ic.cc	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	src/ic/mips/handler-compiler-mips.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/ic/mips64/handler-compiler-mips64.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/ic/x64/handler-compiler-x64.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/ic/x87/handler-compiler-x87.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

ulan

PTAL. This reverts https://codereview.chromium.org/881783003/ because of dromaeo regression and embeds the callback via weak cell.

5 years, 10 months ago (2015-02-19 12:44:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926293004/20001

5 years, 10 months ago (2015-02-19 12:51:08 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 13:10:30 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/e12367827c1c29d407a7eee447d17d3ccb1809ef
Cr-Commit-Position: refs/heads/master@{#26748}