Re-enable some HistoryApiTests

Re-enable some HistoryApiTests

Currently HistoryApiTest.Delete, HistoryApiTest.GetVisits, and HistoryApiTest.SearchAfterAdd are disabled. These do not flake or time out locally nor on the try bots, so this CL re-enables them.

BUG=88318, 79074, 76170
Committed: https://crrev.com/f1c7ab473515bf887dcf628f9c004c3114a5f862
Cr-Commit-Position: refs/heads/master@{#316680}

[hichris123, 2015-02-14 21:32:52]

hichris123@gmail.com changed reviewers:
+ rdevlin.cronin@chromium.org

[hichris123, 2015-02-14 21:53:56]

@rdelvin: Can you take a look at this CL? It re-enables three HistoryApiTests
that were disabled either on Windows only or on all OSs.

I ran these tests with --gtest_repeat=20 locally & on the trybots, and they
didn't fail or flake.

Thanks!

[hichris123, 2015-02-14 22:03:04]

On 2015/02/14 21:53:56, hichris123 wrote:
> @rdelvin: Can you take a look at this CL? It re-enables three HistoryApiTests
> that were disabled either on Windows only or on all OSs.
> 
> I ran these tests with --gtest_repeat=20 locally & on the trybots, and they
> didn't fail or flake.
> 
> Thanks!

by the way: the GN failures are being shown on the main waterfall, so I'm fairly
sure that isn't my fault. Totally spaced putting that in my last message. ;)

[Devlin, 2015-02-17 17:00:37]

lgtm.  It's always worth trying to re-enable some tests. :)

A few thoughts/questions:
- Did you get a chance to test these on multiple platforms (or, at least, on the
platform they were disabled on)?
- Do we know if there's a good reason they might be less flaky now?  This is
kinda ambiguous, since the codebase shifts a bunch, but sometimes it's good to
at least have a hunch of why they failed before, but not now. ;)
- In the future, it might be good to re-enable them one at a time, so if someone
reverts the patchset (instead of just disabling the test), only one test gets
re-disabled.

[hichris123, 2015-02-17 20:53:43]

On 2015/02/17 17:00:37, Devlin wrote:
> lgtm.  It's always worth trying to re-enable some tests. :)
> 
> A few thoughts/questions:
> - Did you get a chance to test these on multiple platforms (or, at least, on
the
> platform they were disabled on)?

I only tested these on Windows locally, but I did run the trybots on all
platforms. Only GetVisits was disabled on all platforms, but bug 79074 only had
the OS-Win label on it, so I'm really not sure there. The other two were only
disabled on Windows.

> - Do we know if there's a good reason they might be less flaky now?  This is
> kinda ambiguous, since the codebase shifts a bunch, but sometimes it's good to
> at least have a hunch of why they failed before, but not now. ;)

Honestly, I have no clue. All of these tests were disabled in 2011/2012, so
three or four years ago. I can imagine there's been a lot of changes to the
codebase since then, so I hope everything was fixed. If not, then we at least
have an up-to-date picture of when it's flaking/crashing.

> - In the future, it might be good to re-enable them one at a time, so if
someone
> reverts the patchset (instead of just disabling the test), only one test gets
> re-disabled.

Okay, good to know. Thanks for telling me!

[hichris123, 2015-02-17 21:16:10]

The CQ bit was checked by hichris123@gmail.com

[commit-bot: I haz the power, 2015-02-17 21:16:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/926283003/1

[commit-bot: I haz the power, 2015-02-17 22:36:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-17 22:37:41]

Patchset 1 (id:??) landed as
https://crrev.com/f1c7ab473515bf887dcf628f9c004c3114a5f862
Cr-Commit-Position: refs/heads/master@{#316680}

[hichris123, 2015-02-21 23:57:02]

Hmm, HistoryApiTest.Delete seems to be flaky still -
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%28....
Looks like results.length in delete.js isn't equaling what it should. I'll take
a look, but if I can't figure out why it's flaking, should we just revert this
CL? Or should I create another CL to re-disable HistoryApiTest.Delete?

[hichris123, 2015-02-22 21:56:31]

On 2015/02/21 23:57:02, hichris123 wrote:
> Hmm, HistoryApiTest.Delete seems to be flaky still -
>
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%28....
> Looks like results.length in delete.js isn't equaling what it should. I'll
take
> a look, but if I can't figure out why it's flaking, should we just revert this
> CL? Or should I create another CL to re-disable HistoryApiTest.Delete?

Actually, SearchAfterAdd seems to be flaky still too -
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%207%20Tests%....

[Devlin, 2015-02-23 16:44:11]

On 2015/02/22 21:56:31, hichris123 wrote:
> On 2015/02/21 23:57:02, hichris123 wrote:
> > Hmm, HistoryApiTest.Delete seems to be flaky still -
> >
>
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%28....
> > Looks like results.length in delete.js isn't equaling what it should. I'll
> take
> > a look, but if I can't figure out why it's flaking, should we just revert
this
> > CL? Or should I create another CL to re-disable HistoryApiTest.Delete?
> 
> Actually, SearchAfterAdd seems to be flaky still too -
>
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%207%20Tests%....

Well, it was worth a shot.  Go ahead and make a new CL to disable any flaky
tests.

[hichris123, 2015-02-23 20:51:37]

On 2015/02/23 16:44:11, Devlin wrote:
> On 2015/02/22 21:56:31, hichris123 wrote:
> > On 2015/02/21 23:57:02, hichris123 wrote:
> > > Hmm, HistoryApiTest.Delete seems to be flaky still -
> > >
> >
>
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%28....
> > > Looks like results.length in delete.js isn't equaling what it should. I'll
> > take
> > > a look, but if I can't figure out why it's flaking, should we just revert
> this
> > > CL? Or should I create another CL to re-disable HistoryApiTest.Delete?
> > 
> > Actually, SearchAfterAdd seems to be flaky still too -
> >
>
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%207%20Tests%....
> 
> Well, it was worth a shot.  Go ahead and make a new CL to disable any flaky
> tests.

All of them are still flaking -- can I just create a revert of this CL?

[Devlin, 2015-02-23 21:10:23]

On 2015/02/23 20:51:37, hichris123 wrote:
> On 2015/02/23 16:44:11, Devlin wrote:
> > On 2015/02/22 21:56:31, hichris123 wrote:
> > > On 2015/02/21 23:57:02, hichris123 wrote:
> > > > Hmm, HistoryApiTest.Delete seems to be flaky still -
> > > >
> > >
> >
>
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%28....
> > > > Looks like results.length in delete.js isn't equaling what it should.
I'll
> > > take
> > > > a look, but if I can't figure out why it's flaking, should we just
revert
> > this
> > > > CL? Or should I create another CL to re-disable HistoryApiTest.Delete?
> > > 
> > > Actually, SearchAfterAdd seems to be flaky still too -
> > >
> >
>
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%207%20Tests%....
> > 
> > Well, it was worth a shot.  Go ahead and make a new CL to disable any flaky
> > tests.
> 
> All of them are still flaking -- can I just create a revert of this CL?

Ah, didn't realize it was all 3.  Yeah, you can just revert this one.

[hichris123, 2015-02-23 21:18:06]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/943413003/ by hichris123@gmail.com.

The reason for reverting is: All of these tests are still flaky, so reverting it
will re-disable the tests..