Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 926263002: Android Chromoting: Don't auto-reconnect if connection was established. (Closed)

Created:
5 years, 10 months ago by Lambros
Modified:
5 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Chromoting: Don't auto-reconnect if connection was established. If the Linux host is killed (due to changing PIN or other reason), the Android client sees that the connection has failed with error PEER_IS_OFFLINE. This is the same error that would occur if the JID were stale, which the client normally handles by auto-reloading the host-list and reconnecting. But since the session was already connected, the Desktop activity does not properly get torn down and re-initialized (which is something to address at a future date). This CL fixes the linked bug by ensuring that the automatic reload does not happen after a successful connection. BUG=424759 Committed: https://crrev.com/95543b346a8712aa97226a5201d9c1df0ce34807 Cr-Commit-Position: refs/heads/master@{#316686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M remoting/android/java/src/org/chromium/chromoting/SessionConnector.java View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Lambros
5 years, 10 months ago (2015-02-14 02:21:42 UTC) #2
Jamie
lgtm
5 years, 10 months ago (2015-02-17 22:22:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926263002/1
5 years, 10 months ago (2015-02-17 22:33:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 22:50:14 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:50:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95543b346a8712aa97226a5201d9c1df0ce34807
Cr-Commit-Position: refs/heads/master@{#316686}

Powered by Google App Engine
This is Rietveld 408576698