Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 926173002: Run pixel tests via automated script. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run pixel tests via automated script. On origin/master, we only have .ppm format support, so the expected output files would take up a lot of space. Hence, this may not get going until XFA hits with its .png support. Nor is there a good way to diff these; XFA provides this for .png as well. But this will provide at least one automated test to ensure that we've got non-blank output, at least for one trivially simple case. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7435e8e5c2f1163ec5eca79a3ac6c3920d490578

Patch Set 1 #

Patch Set 2 : Check multiple pages. #

Total comments: 2

Patch Set 3 : Use %d. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -8 lines) Patch
A testing/resources/pixel/font_size.in View 1 chunk +62 lines, -0 lines 0 comments Download
A testing/resources/pixel/font_size_expected.pdf.0.ppm View Binary file 0 comments Download
A + testing/tools/run_pixel_tests.py View 1 2 3 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Tom Sepez
For completeness.
5 years, 10 months ago (2015-02-13 22:44:19 UTC) #2
Lei Zhang
lgtm This assumes the tests are just a single page, right? There's a typo in ...
5 years, 10 months ago (2015-02-13 23:09:04 UTC) #3
Tom Sepez
On 2015/02/13 23:09:04, Lei Zhang wrote: > lgtm > > This assumes the tests are ...
5 years, 10 months ago (2015-02-14 00:16:34 UTC) #4
Tom Sepez
Ok, lets try again, I also fixed an issue with the root directory not always ...
5 years, 10 months ago (2015-02-14 00:34:51 UTC) #6
Lei Zhang
https://codereview.chromium.org/926173002/diff/20001/testing/tools/run_pixel_tests.py File testing/tools/run_pixel_tests.py (right): https://codereview.chromium.org/926173002/diff/20001/testing/tools/run_pixel_tests.py#newcode23 testing/tools/run_pixel_tests.py:23: actual_path_template = os.path.join(working_dir, input_root + '.pdf.%s.ppm') Shouldn't that be ...
5 years, 10 months ago (2015-02-14 00:39:44 UTC) #7
Tom Sepez
https://codereview.chromium.org/926173002/diff/20001/testing/tools/run_pixel_tests.py File testing/tools/run_pixel_tests.py (right): https://codereview.chromium.org/926173002/diff/20001/testing/tools/run_pixel_tests.py#newcode23 testing/tools/run_pixel_tests.py:23: actual_path_template = os.path.join(working_dir, input_root + '.pdf.%s.ppm') On 2015/02/14 00:39:43, ...
5 years, 10 months ago (2015-02-14 00:44:50 UTC) #8
Lei Zhang
lgtm++
5 years, 10 months ago (2015-02-14 00:46:16 UTC) #9
Tom Sepez
5 years, 10 months ago (2015-02-14 00:47:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7435e8e5c2f1163ec5eca79a3ac6c3920d490578 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698