Issue 926163002: Program _uriBaseClosure into the DartVM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 926163002: Program _uriBaseClosure into the DartVM (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
esprehn, ojan

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Program _uriBaseClosure into the DartVM Turns out you need a base URI to make the unit testing framework behave in a sane way. R=esprehn@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f63ef8b17e0d2b72baa54dc65ec8290591a8fac4

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	sky/engine/bindings/builtin.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	sky/engine/bindings/builtin_natives.cc	View		4 chunks	+16 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 10 months ago (2015-02-13 22:41:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f63ef8b17e0d2b72baa54dc65ec8290591a8fac4 (presubmit successful).