Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 926113005: Remove InputType::shouldRespectSpeechAttribute (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove InputType::shouldRespectSpeechAttribute This check method is from 2011 but does not seem used anymore. BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M Source/core/html/forms/InputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/NumberInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/PasswordInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/PasswordInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/SearchInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/TelephoneInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/TelephoneInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/TextInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/TextInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 10 months ago (2015-02-13 22:57:02 UTC) #2
tkent
lgtm
5 years, 10 months ago (2015-02-16 01:35:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926113005/1
5 years, 10 months ago (2015-02-16 01:35:21 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 02:38:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190194

Powered by Google App Engine
This is Rietveld 408576698