Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 926093002: Remove dependency on autofill_core_browser from policy_component. (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on autofill_core_browser from policy_component. policy_component doesn't need to depend on autofill_core_browser. Also added dependency on gfx_geometry in favicon_base. policy_component was failing to compile without it. BUG=458581 Committed: https://crrev.com/202c0025407999db640d5983144d750733b866af Cr-Commit-Position: refs/heads/master@{#317118}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M components/favicon_base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/favicon_base/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/policy/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/policy_browser.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Sergey Ulanov
atwilson@chromium.org - component/policy stevenjb@chromium.org - component/favicon_base.gypi
5 years, 10 months ago (2015-02-13 18:27:57 UTC) #3
stevenjb
owner lgtm
5 years, 10 months ago (2015-02-13 18:48:02 UTC) #4
Sergey Ulanov
+bartfab@, can you please review changes components/policy/? Thanks!
5 years, 10 months ago (2015-02-18 21:36:16 UTC) #8
bartfab (slow)
lgtm
5 years, 10 months ago (2015-02-19 10:35:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926093002/40001
5 years, 10 months ago (2015-02-19 19:30:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-19 20:10:47 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 20:11:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/202c0025407999db640d5983144d750733b866af
Cr-Commit-Position: refs/heads/master@{#317118}

Powered by Google App Engine
This is Rietveld 408576698