Decouple web_view.js from attribute internals

extensions/renderer/resources/guest_view/web_view_attributes.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements the attributes of the <webview> tag.
 
 var GuestViewInternal =
     require('binding').Binding.create('guestViewInternal').generate();
 var WebViewImpl = require('webView').WebViewImpl;
 var WebViewConstants = require('webViewConstants').WebViewConstants;
@@ skipping 46 matching lines @@
   if (this.ignoreMutation) {
     return;
   }
 
   this.handleMutation(oldValue, newValue);
 };
 
 // Called when a change that isn't ignored occurs to the attribute's value.
 WebViewAttribute.prototype.handleMutation = function(oldValue, newValue) {};
 
+// Called when the <webview> element is detached from the DOM tree.
+WebViewAttribute.prototype.reset = function() {};
+
 // An attribute that is treated as a Boolean.
 function BooleanAttribute(name, webViewImpl) {
   WebViewAttribute.call(this, name, webViewImpl);
 }
 
 BooleanAttribute.prototype.__proto__ = WebViewAttribute.prototype;
 
 BooleanAttribute.prototype.getValue = function() {
   return this.webViewImpl.element.hasAttribute(this.name);
 };
@@ skipping 92 matching lines @@
       this, WebViewConstants.ATTRIBUTE_PARTITION, webViewImpl);
   this.validPartitionId = true;
 }
 
 PartitionAttribute.prototype.__proto__ = WebViewAttribute.prototype;
 
 PartitionAttribute.prototype.handleMutation = function(oldValue, newValue) {
   newValue = newValue || '';
 
   // The partition cannot change if the webview has already navigated.
-  if (!this.webViewImpl.beforeFirstNavigation) {
+  if (!this.webViewImpl.attributes[
+        WebViewConstants.ATTRIBUTE_SRC].beforeFirstNavigation) {
     window.console.error(WebViewConstants.ERROR_MSG_ALREADY_NAVIGATED);
     this.setValueIgnoreMutation(oldValue);
     return;
   }
   if (newValue == 'persist:') {
     this.validPartitionId = false;
     window.console.error(
         WebViewConstants.ERROR_MSG_INVALID_PARTITION_ATTRIBUTE);
   }
 };
 
+PartitionAttribute.prototype.reset = function() {
+  this.validPartitionId = true;
+};
+
 // Attribute that handles the location and navigation of the webview.
 function SrcAttribute(webViewImpl) {
   WebViewAttribute.call(this, WebViewConstants.ATTRIBUTE_SRC, webViewImpl);
   this.setupMutationObserver();
+  this.beforeFirstNavigation = true;
 }
 
 SrcAttribute.prototype.__proto__ = WebViewAttribute.prototype;
 
 SrcAttribute.prototype.setValueIgnoreMutation = function(value) {
   // takeRecords() is needed to clear queued up src mutations. Without it, it is
   // possible for this change to get picked up asyncronously by src's mutation
   // observer |observer|, and then get handled even though we do not want to
   // handle this mutation.
   this.observer.takeRecords();
   this.ignoreMutation = true;
   this.webViewImpl.element.setAttribute(this.name, value || '');
   this.ignoreMutation = false;
 }
 
 SrcAttribute.prototype.handleMutation = function(oldValue, newValue) {
   // Once we have navigated, we don't allow clearing the src attribute.
   // Once <webview> enters a navigated state, it cannot return to a
   // placeholder state.
   if (!newValue && oldValue) {
     // src attribute changes normally initiate a navigation. We suppress
     // the next src attribute handler call to avoid reloading the page
     // on every guest-initiated navigation.
     this.setValueIgnoreMutation(oldValue);
     return;
   }
   this.parse();
 };
 
+SrcAttribute.prototype.reset = function() {
+  this.beforeFirstNavigation = true;
+};
+
 // The purpose of this mutation observer is to catch assignment to the src
 // attribute without any changes to its value. This is useful in the case
 // where the webview guest has crashed and navigating to the same address
 // spawns off a new process.
 SrcAttribute.prototype.setupMutationObserver =
     function() {
   this.observer = new MutationObserver(function(mutations) {
     $Array.forEach(mutations, function(mutation) {
       var oldValue = mutation.oldValue;
       var newValue = this.getValue();
@@ skipping 13 matching lines @@
 
 SrcAttribute.prototype.parse = function() {
   if (!this.webViewImpl.elementAttached ||
       !this.webViewImpl.attributes[
         WebViewConstants.ATTRIBUTE_PARTITION].validPartitionId ||
       !this.getValue()) {
     return;
   }
 
   if (!this.webViewImpl.guest.getId()) {
-    if (this.webViewImpl.beforeFirstNavigation) {
-      this.webViewImpl.beforeFirstNavigation = false;
+    if (this.beforeFirstNavigation) {
+      this.beforeFirstNavigation = false;
       this.webViewImpl.createGuest();
     }
     return;
   }
 
   // Navigate to |src|.
   WebViewInternal.navigate(this.webViewImpl.guest.getId(), this.getValue());
 };
 
 // -----------------------------------------------------------------------------
@@ skipping 15 matching lines @@
 
   var autosizeAttributes = [WebViewConstants.ATTRIBUTE_MAXHEIGHT,
                             WebViewConstants.ATTRIBUTE_MAXWIDTH,
                             WebViewConstants.ATTRIBUTE_MINHEIGHT,
                             WebViewConstants.ATTRIBUTE_MINWIDTH];
   for (var i = 0; autosizeAttributes[i]; ++i) {
     this.attributes[autosizeAttributes[i]] =
         new AutosizeDimensionAttribute(autosizeAttributes[i], this);
   }
 };