Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 926023002: [Android] Do not overwrite command when using the run_pie wrapper. (Closed)

Created:
5 years, 10 months ago by Raphael Kubo da Costa (rakuco)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Do not overwrite command when using the run_pie wrapper. Some change starting in M41 has started causing an existing bug in GetAndroidToolsStatusAndOutput() to fail in ICS devices. When the run_pie wrapper needs to be used, the call to `adb push' ends up overwriting the original command that was going to be run on the device, and the instrumentation tests fail like this: > LD_LIBRARY_PATH=/data/local/tmp/forwarder/ /data/local/tmp/run_pie push /path/in/host/out/Release/run_pie /data/local/tmp/run_pie; echo %$? [...] [PIE Loader] dlopen() failed: Cannot load library: load_library[1095]: Library 'push' not found. Fix it by using a different variable name for the `adb push' command that must be run on the host. BUG=373219 R=primiano@chromium.org, torne@chromium.org Committed: https://crrev.com/2dca4da271cbab6f53832d98cc79a874a4e4244c Cr-Commit-Position: refs/heads/master@{#316233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/android_commands.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Raphael Kubo da Costa (rakuco)
5 years, 10 months ago (2015-02-13 15:50:26 UTC) #2
jbudorick
lgtm
5 years, 10 months ago (2015-02-13 15:54:07 UTC) #3
jbudorick
On 2015/02/13 15:54:07, jbudorick wrote: > lgtm and thanks for the patch!
5 years, 10 months ago (2015-02-13 15:55:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926023002/1
5 years, 10 months ago (2015-02-13 16:00:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 17:31:00 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 17:31:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dca4da271cbab6f53832d98cc79a874a4e4244c
Cr-Commit-Position: refs/heads/master@{#316233}

Powered by Google App Engine
This is Rietveld 408576698