Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 926013002: TF: Add support for [[HomeObject]] (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

TF: Add support for [[HomeObject]] BUG=None LOG=N R=mstarzinger@chromium.org, dslomov@chromium.org Committed: https://crrev.com/d273636e0101fab763fcafb91a5daa3aed078048 Cr-Commit-Position: refs/heads/master@{#26641}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +5 lines, -0 lines 1 comment Download
M src/compiler/ast-graph-builder.cc View 6 chunks +20 lines, -9 lines 1 comment Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-13 15:21:17 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-13 16:18:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926013002/1
5 years, 10 months ago (2015-02-13 18:12:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 18:33:49 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d273636e0101fab763fcafb91a5daa3aed078048 Cr-Commit-Position: refs/heads/master@{#26641}
5 years, 10 months ago (2015-02-13 18:34:10 UTC) #6
Michael Starzinger
https://codereview.chromium.org/926013002/diff/1/src/compiler/ast-graph-builder.h File src/compiler/ast-graph-builder.h (right): https://codereview.chromium.org/926013002/diff/1/src/compiler/ast-graph-builder.h#newcode232 src/compiler/ast-graph-builder.h:232: void AddHomeObjectIfNeeded(Expression* expr, Node* function, Single "Add" method not ...
5 years, 10 months ago (2015-02-16 18:17:51 UTC) #7
Michael Starzinger
5 years, 10 months ago (2015-02-16 18:36:01 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/926013002/diff/1/src/compiler/ast-graph-build...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/926013002/diff/1/src/compiler/ast-graph-build...
src/compiler/ast-graph-builder.cc:1547: VisitForValueOrNull(it->second->setter);
If we ever deoptimize while evaluating the setter then the HomeObject for the
getter won't be set yet, but full-codegen will not set it because the ordering
is different in full-codegen. Not sure if evaluating the FunctionLiteral could
ever cause a deopt though.

Powered by Google App Engine
This is Rietveld 408576698