PasswordAutofillAgent: only check visibility if needed

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 875 matching lines @@
   }
 
   blink::WebVector<blink::WebFormElement> forms;
   frame->document().forms(forms);
   if (logger)
     logger->LogNumber(Logger::STRING_NUMBER_OF_ALL_FORMS, forms.size());
 
   std::vector<PasswordForm> password_forms;
   for (size_t i = 0; i < forms.size(); ++i) {
     const blink::WebFormElement& form = forms[i];
-    bool is_form_visible = IsWebNodeVisible(form);
-    if (logger) {
-      LogHTMLForm(logger.get(), Logger::STRING_FORM_FOUND_ON_PAGE, form);
-      logger->LogBoolean(Logger::STRING_FORM_IS_VISIBLE, is_form_visible);
+    if (only_visible) {
+      bool is_form_visible = IsWebNodeVisible(form);
+      if (logger) {
+        LogHTMLForm(logger.get(), Logger::STRING_FORM_FOUND_ON_PAGE, form);
+        logger->LogBoolean(Logger::STRING_FORM_IS_VISIBLE, is_form_visible);
+      }
+
+      // If requested, ignore non-rendered forms, e.g., those styled with
+      // display:none.
+      if (!is_form_visible)
+        continue;
     }
 
-    // If requested, ignore non-rendered forms, e.g. those styled with
-    // display:none.
-    if (only_visible && !is_form_visible)
-      continue;
-
     scoped_ptr<PasswordForm> password_form(CreatePasswordForm(form, nullptr));
     if (password_form.get()) {
       if (logger) {
         logger->LogPasswordForm(Logger::STRING_FORM_IS_PASSWORD,
                                 *password_form);
       }
       password_forms.push_back(*password_form);
     }
   }
 
@@ skipping 460 matching lines @@
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::DidStopLoading() {
   agent_->DidStopLoading();
 }
 
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::
     DidStartProvisionalLoad(blink::WebLocalFrame* navigated_frame) {
   agent_->LegacyDidStartProvisionalLoad(navigated_frame);
 }
 
 }  // namespace autofill