Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Side by Side Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 925973002: Fix error handling in dart2js async-await (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 class SsaFunctionCompiler implements FunctionCompiler { 7 class SsaFunctionCompiler implements FunctionCompiler {
8 SsaCodeGeneratorTask generator; 8 SsaCodeGeneratorTask generator;
9 SsaBuilderTask builder; 9 SsaBuilderTask builder;
10 SsaOptimizerTask optimizer; 10 SsaOptimizerTask optimizer;
11 11
12 SsaFunctionCompiler(JavaScriptBackend backend, bool generateSourceMap) 12 SsaFunctionCompiler(JavaScriptBackend backend, bool generateSourceMap)
13 : generator = new SsaCodeGeneratorTask(backend), 13 : generator = new SsaCodeGeneratorTask(backend),
14 builder = new SsaBuilderTask(backend, generateSourceMap), 14 builder = new SsaBuilderTask(backend, generateSourceMap),
15 optimizer = new SsaOptimizerTask(backend); 15 optimizer = new SsaOptimizerTask(backend);
16 16
17 /// Generates JavaScript code for `work.element`. 17 /// Generates JavaScript code for `work.element`.
18 /// Using the ssa builder, optimizer and codegenerator. 18 /// Using the ssa builder, optimizer and codegenerator.
19 js.Fun compile(CodegenWorkItem work) { 19 js.Fun compile(CodegenWorkItem work) {
20 HGraph graph = builder.build(work); 20 HGraph graph = builder.build(work);
21 optimizer.optimize(work, graph); 21 optimizer.optimize(work, graph);
22 Element element = work.element; 22 Element element = work.element;
23 js.Expression result = generator.generateCode(work, graph); 23 js.Expression result = generator.generateCode(work, graph);
24 if (element is FunctionElement) { 24 if (element is FunctionElement) {
25 JavaScriptBackend backend = builder.backend; 25 JavaScriptBackend backend = builder.backend;
26 26
27 AsyncRewriter rewriter = null; 27 AsyncRewriter rewriter = null;
28
28 if (element.asyncMarker == AsyncMarker.ASYNC) { 29 if (element.asyncMarker == AsyncMarker.ASYNC) {
29 rewriter = new AsyncRewriter( 30 rewriter = new AsyncRewriter(
30 backend.compiler, 31 backend.compiler,
31 backend.compiler.currentElement, 32 backend.compiler.currentElement,
32 thenHelper: 33 asyncHelper:
33 backend.emitter.staticFunctionAccess(backend.getThenHelper()), 34 backend.emitter.staticFunctionAccess(backend.getAsyncHelper()),
34 newCompleter: backend.emitter.staticFunctionAccess( 35 newCompleter: backend.emitter.staticFunctionAccess(
35 backend.getCompleterConstructor()), 36 backend.getCompleterConstructor()),
36 safeVariableName: backend.namer.safeVariableName); 37 safeVariableName: backend.namer.safeVariableName);
37 } else if (element.asyncMarker == AsyncMarker.SYNC_STAR) { 38 } else if (element.asyncMarker == AsyncMarker.SYNC_STAR) {
38 rewriter = new AsyncRewriter( 39 rewriter = new AsyncRewriter(
39 backend.compiler, 40 backend.compiler,
40 backend.compiler.currentElement, 41 backend.compiler.currentElement,
41 endOfIteration: backend.emitter.staticFunctionAccess( 42 endOfIteration: backend.emitter.staticFunctionAccess(
42 backend.getEndOfIteration()), 43 backend.getEndOfIteration()),
43 newIterable: backend.emitter.staticFunctionAccess( 44 newIterable: backend.emitter.staticFunctionAccess(
44 backend.getSyncStarIterableConstructor()), 45 backend.getSyncStarIterableConstructor()),
45 yieldStarExpression: backend.emitter.staticFunctionAccess( 46 yieldStarExpression: backend.emitter.staticFunctionAccess(
46 backend.getYieldStar()), 47 backend.getYieldStar()),
48 uncaughtErrorExpression: backend.emitter.staticFunctionAccess(
49 backend.getSyncStarUncaughtError()),
47 safeVariableName: backend.namer.safeVariableName); 50 safeVariableName: backend.namer.safeVariableName);
48 } 51 }
49 else if (element.asyncMarker == AsyncMarker.ASYNC_STAR) { 52 else if (element.asyncMarker == AsyncMarker.ASYNC_STAR) {
50 rewriter = new AsyncRewriter( 53 rewriter = new AsyncRewriter(
51 backend.compiler, 54 backend.compiler,
52 backend.compiler.currentElement, 55 backend.compiler.currentElement,
53 streamHelper: backend.emitter.staticFunctionAccess( 56 streamHelper: backend.emitter.staticFunctionAccess(
54 backend.getStreamHelper()), 57 backend.getAsyncStarHelper()),
55 streamOfController: backend.emitter.staticFunctionAccess( 58 streamOfController: backend.emitter.staticFunctionAccess(
56 backend.getStreamOfController()), 59 backend.getStreamOfController()),
57 newController: backend.emitter.staticFunctionAccess( 60 newController: backend.emitter.staticFunctionAccess(
58 backend.getASyncStarControllerConstructor()), 61 backend.getASyncStarControllerConstructor()),
59 safeVariableName: backend.namer.safeVariableName, 62 safeVariableName: backend.namer.safeVariableName,
60 yieldExpression: backend.emitter.staticFunctionAccess( 63 yieldExpression: backend.emitter.staticFunctionAccess(
61 backend.getYieldSingle()), 64 backend.getYieldSingle()),
62 yieldStarExpression: backend.emitter.staticFunctionAccess( 65 yieldStarExpression: backend.emitter.staticFunctionAccess(
63 backend.getYieldStar())); 66 backend.getYieldStar()));
64 } 67 }
(...skipping 6850 matching lines...) Expand 10 before | Expand all | Expand 10 after
6915 if (unaliased is TypedefType) throw 'unable to unalias $type'; 6918 if (unaliased is TypedefType) throw 'unable to unalias $type';
6916 unaliased.accept(this, builder); 6919 unaliased.accept(this, builder);
6917 } 6920 }
6918 6921
6919 void visitDynamicType(DynamicType type, SsaBuilder builder) { 6922 void visitDynamicType(DynamicType type, SsaBuilder builder) {
6920 JavaScriptBackend backend = builder.compiler.backend; 6923 JavaScriptBackend backend = builder.compiler.backend;
6921 ClassElement cls = backend.findHelper('DynamicRuntimeType'); 6924 ClassElement cls = backend.findHelper('DynamicRuntimeType');
6922 builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld))); 6925 builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld)));
6923 } 6926 }
6924 } 6927 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698