Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 925963002: Cleanup owners files, histograms, src (-ygorshenin@) (Closed)

Created:
5 years, 10 months ago by Nikita (slow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup owners files, src code. Remove ygorshenin@ from OWNERS/TODOs, replace with alemate/antrim/dpolukhin/bartfab BUG=None TBR=stevenjb@chromium.org,isherman@chromium.org Committed: https://crrev.com/1b9ac7da07d08fcae7bcd1f3fa251c1d6b6611bb Cr-Commit-Position: refs/heads/master@{#316554}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -59 lines) Patch
M WATCHLISTS View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/net/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/ownership/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/reset/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/portal_detector/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M components/OWNERS View 2 chunks +0 lines, -2 lines 0 comments Download
M components/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/ownership/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M components/session_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/user_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 9 chunks +10 lines, -10 lines 0 comments Download
M ui/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
Nikita (slow)
dpolukhin@ - please review whole CL bartfab@ for chrome/browser/chromeos/settings/OWNERS alemate@ for chromeos/network/portal_detector/OWNERS components/ownership/OWNERS tools/metrics/histograms/histograms.xml antrim@ ...
5 years, 10 months ago (2015-02-13 13:43:17 UTC) #2
Denis Kuznetsov (DE-MUC)
lgtm on my side
5 years, 10 months ago (2015-02-13 17:33:33 UTC) #3
blundell
//components lgtm
5 years, 10 months ago (2015-02-16 08:24:11 UTC) #4
Dmitry Polukhin
lgtm
5 years, 10 months ago (2015-02-16 08:25:54 UTC) #5
bartfab (slow)
chrome/browser/chromeos/settings/OWNERS LGTM
5 years, 10 months ago (2015-02-16 11:08:06 UTC) #6
Alexander Alekseev
lgtm for: chromeos/network/portal_detector/OWNERS components/ownership/OWNERS tools/metrics/histograms/histograms.xml
5 years, 10 months ago (2015-02-16 16:14:51 UTC) #8
Nikita (slow)
On 2015/02/13 13:43:17, Nikita wrote: > stevenjb@ for chromeos/network/* > (btw, let me know if ...
5 years, 10 months ago (2015-02-17 08:57:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925963002/60001
5 years, 10 months ago (2015-02-17 08:58:11 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-17 10:20:47 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1b9ac7da07d08fcae7bcd1f3fa251c1d6b6611bb Cr-Commit-Position: refs/heads/master@{#316554}
5 years, 10 months ago (2015-02-17 10:21:35 UTC) #13
Ilya Sherman
5 years, 10 months ago (2015-02-17 21:52:06 UTC) #14
Message was sent while issue was closed. 
histograms.xml lgtm

Powered by Google App Engine
This is Rietveld 408576698