Make Geolocation internal test methods more resilient.

Source/modules/geolocation/testing/InternalsGeolocation.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 26 matching lines @@
 #include "modules/geolocation/GeolocationController.h"
 #include "modules/geolocation/GeolocationError.h"
 #include "modules/geolocation/GeolocationPosition.h"
 #include "modules/geolocation/testing/GeolocationClientMock.h"
 #include "wtf/CurrentTime.h"
 
 namespace blink {
 
 void InternalsGeolocation::setGeolocationClientMock(Internals&, Document* document)
 {
-    ASSERT(document && document->frame());
+    ASSERT(document);
+    if (!document->frame())
+        return;
+
     GeolocationClientMock* client = new GeolocationClientMock();
-
     for (Frame* childFrame = document->page()->mainFrame(); childFrame; childFrame = childFrame->tree().traverseNext()) {
         if (childFrame->isLocalFrame())
             GeolocationController::from(toLocalFrame(childFrame))->setClientForTest(client);
     }
 }
 
 void InternalsGeolocation::setGeolocationPosition(Internals&, Document* document, double latitude, double longitude, double accuracy)
 {
-    ASSERT(document && document->frame());
+    ASSERT(document);
+    if (!document->frame())
+        return;
+
     GeolocationClientMock* client = geolocationClient(document);
     if (!client)
         return;
     client->setPosition(GeolocationPosition::create(currentTime(), latitude, longitude, accuracy));
 }
 
 void InternalsGeolocation::setGeolocationPositionUnavailableError(Internals&, Document* document, const String& message)
 {
-    ASSERT(document && document->frame());
+    ASSERT(document);
+    if (!document->frame())
+        return;
+
     GeolocationClientMock* client = geolocationClient(document);
     if (!client)
         return;
     client->setPositionUnavailableError(message);
 }
 
 void InternalsGeolocation::setGeolocationPermission(Internals&, Document* document, bool allowed)
 {
-    ASSERT(document && document->frame());
+    ASSERT(document);
+    if (!document->frame())
+        return;
+
     GeolocationClientMock* client = geolocationClient(document);
     if (!client)
         return;
     client->setPermission(allowed);
 }
 
 int InternalsGeolocation::numberOfPendingGeolocationPermissionRequests(Internals&, Document* document)
 {
-    ASSERT(document && document->frame());
+    ASSERT(document);
+    if (!document->frame())
+        return -1;
+
     GeolocationClientMock* client = geolocationClient(document);
     if (!client)
         return -1;
     return client->numberOfPendingPermissionRequests();
 }
 
 GeolocationClientMock* InternalsGeolocation::geolocationClient(Document* document)
 {
+    ASSERT(document);
+    if (!document->frame())
+        return nullptr;
+
     GeolocationController* controller = GeolocationController::from(document->frame());
     if (!controller->hasClientForTest())
-        return 0;
+        return nullptr;
     return static_cast<GeolocationClientMock*>(controller->client());
 }
 
 } // namespace blink