Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 925953003: Make Geolocation internal test methods more resilient. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make Geolocation internal test methods more resilient. Have the window.internals Geolocation test methods typecheck its arguments, throwing TypeError if passed invalid Document arguments. Additionally, have the methods gracefully handle detached documents. R=tkent BUG=460550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -9 lines) Patch
A + LayoutTests/fast/dom/Geolocation/invalid-internals-arguments-no-crash.html View 1 chunk +3 lines, -1 line 0 comments Download
A LayoutTests/fast/dom/Geolocation/invalid-internals-arguments-no-crash-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Geolocation/script-tests/invalid-internals-arguments.js View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/modules/geolocation/testing/InternalsGeolocation.cpp View 6 chunks +25 lines, -7 lines 0 comments Download
M Source/modules/geolocation/testing/InternalsGeolocation.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look. Avoiding clusterfuzz disturbance, if nothing else.
5 years, 10 months ago (2015-02-23 07:43:29 UTC) #2
tkent
I don't think we need tests for internals functions. anyway, lgtm.
5 years, 10 months ago (2015-02-23 07:46:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925953003/1
5 years, 10 months ago (2015-02-23 08:15:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190642
5 years, 10 months ago (2015-02-23 08:45:28 UTC) #6
Michael van Ouwerkerk
5 years, 10 months ago (2015-02-23 10:10:26 UTC) #8
Message was sent while issue was closed.
lgtm thanks!

Powered by Google App Engine
This is Rietveld 408576698