sky/engine/web/WebViewImpl.h - Issue 925933004: Prune HitTestResult and stop special-casing links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/web/WebViewImpl.h

Issue 925933004: Prune HitTestResult and stop special-casing links. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: address review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/web/WebViewImpl.h

diff --git a/sky/engine/web/WebViewImpl.h b/sky/engine/web/WebViewImpl.h

index 9998e7df568e0bb9e6499df2255a34b0a93b12e1..a85effc27a20b522adfe77abba08dc934f6801ba 100644

--- a/sky/engine/web/WebViewImpl.h

+++ b/sky/engine/web/WebViewImpl.h

@@ -105,7 +105,6 @@ public:

virtual float deviceScaleFactor() const override;

virtual void setDeviceScaleFactor(float) override;

- virtual WebHitTestResult hitTestResultAt(const WebPoint&) override;

virtual void spellingMarkers(WebVector<uint32_t>* markers) override;

virtual void removeSpellingMarkersUnderWords(const WebVector<WebString>& words) override;

@@ -115,8 +114,6 @@ public:

virtual void acceptLanguagesChanged() override;

// WebViewImpl

- HitTestResult coreHitTestResultAt(const WebPoint&);

void setBackgroundColorOverride(WebColor);

Color baseBackgroundColor() const { return m_baseBackgroundColor; }

« no previous file with comments | « sky/engine/web/WebHitTestResult.cpp ('k') | sky/engine/web/WebViewImpl.cpp » ('j') | no next file with comments »