Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: sky/engine/web/WebViewImpl.h

Issue 925933004: Prune HitTestResult and stop special-casing links. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: address review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/web/WebHitTestResult.cpp ('k') | sky/engine/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 virtual WebFrame* mainFrame() override; 98 virtual WebFrame* mainFrame() override;
99 virtual WebFrame* focusedFrame() override; 99 virtual WebFrame* focusedFrame() override;
100 virtual void setFocusedFrame(WebFrame*) override; 100 virtual void setFocusedFrame(WebFrame*) override;
101 virtual void setInitialFocus(bool reverse) override; 101 virtual void setInitialFocus(bool reverse) override;
102 virtual void clearFocusedElement() override; 102 virtual void clearFocusedElement() override;
103 virtual void advanceFocus(bool reverse) override; 103 virtual void advanceFocus(bool reverse) override;
104 104
105 virtual float deviceScaleFactor() const override; 105 virtual float deviceScaleFactor() const override;
106 virtual void setDeviceScaleFactor(float) override; 106 virtual void setDeviceScaleFactor(float) override;
107 107
108 virtual WebHitTestResult hitTestResultAt(const WebPoint&) override;
109 virtual void spellingMarkers(WebVector<uint32_t>* markers) override; 108 virtual void spellingMarkers(WebVector<uint32_t>* markers) override;
110 virtual void removeSpellingMarkersUnderWords(const WebVector<WebString>& wor ds) override; 109 virtual void removeSpellingMarkersUnderWords(const WebVector<WebString>& wor ds) override;
111 110
112 virtual void setShowPaintRects(bool) override; 111 virtual void setShowPaintRects(bool) override;
113 void setShowDebugBorders(bool); 112 void setShowDebugBorders(bool);
114 113
115 virtual void acceptLanguagesChanged() override; 114 virtual void acceptLanguagesChanged() override;
116 115
117 // WebViewImpl 116 // WebViewImpl
118 HitTestResult coreHitTestResultAt(const WebPoint&);
119
120 void setBackgroundColorOverride(WebColor); 117 void setBackgroundColorOverride(WebColor);
121 118
122 Color baseBackgroundColor() const { return m_baseBackgroundColor; } 119 Color baseBackgroundColor() const { return m_baseBackgroundColor; }
123 120
124 LocalFrame* focusedCoreFrame() const; 121 LocalFrame* focusedCoreFrame() const;
125 122
126 // Returns the currently focused Element or null if no element has focus. 123 // Returns the currently focused Element or null if no element has focus.
127 Element* focusedElement() const; 124 Element* focusedElement() const;
128 125
129 static WebViewImpl* fromPage(Page*); 126 static WebViewImpl* fromPage(Page*);
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 WebColor m_backgroundColorOverride; 250 WebColor m_backgroundColorOverride;
254 }; 251 };
255 252
256 // We have no ways to check if the specified WebView is an instance of 253 // We have no ways to check if the specified WebView is an instance of
257 // WebViewImpl because WebViewImpl is the only implementation of WebView. 254 // WebViewImpl because WebViewImpl is the only implementation of WebView.
258 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 255 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
259 256
260 } // namespace blink 257 } // namespace blink
261 258
262 #endif // SKY_ENGINE_WEB_WEBVIEWIMPL_H_ 259 #endif // SKY_ENGINE_WEB_WEBVIEWIMPL_H_
OLDNEW
« no previous file with comments | « sky/engine/web/WebHitTestResult.cpp ('k') | sky/engine/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698