Verify all parsed test font files start with cap.

src/ports/SkFontConfigParser_android.cpp

 /*
  * Copyright 2011 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkFontConfigParser_android.h"
 #include "SkFontMgr_android.h"
 #include "SkStream.h"
@@ skipping 431 matching lines @@
 
     // Disable entity processing, to inhibit internal entity expansion. See expat CVE-2013-0340
     XML_SetEntityDeclHandler(parser, xml_entity_decl_handler);
 
     // Start parsing oldschool; switch these in flight if we detect a newer version of the file.
     XML_SetElementHandler(parser, jbParser::start_element_handler, jbParser::end_element_handler);
 
     // One would assume it would be faster to have a buffer on the stack and call XML_Parse.
     // But XML_Parse will call XML_GetBuffer anyway and memmove the passed buffer into it.
     // (Unless XML_CONTEXT_BYTES is undefined, but all users define it.)
-    static const int bufferSize = 512;
+    // In debug, buffer a small odd number of bytes to detect slicing in XML_CharacterDataHandler.
+    static const int bufferSize = 512 SkDEBUGCODE( - 507);
     bool done = false;
     while (!done) {
         void* buffer = XML_GetBuffer(parser, bufferSize);
         if (!buffer) {
             SkDebugf("Could not buffer enough to continue.\n");
             return -1;
         }
         size_t len = file.read(buffer, bufferSize);
         done = file.isAtEnd();
         XML_Status status = XML_ParseBuffer(parser, len, done);
@@ skipping 38 matching lines @@
     // The framework is beyond Android 4.2 and can therefore skip this function
     return;
 #endif
 
     SkAutoTCallIProc<DIR, closedir> fontDirectory(opendir(dir));
     if (NULL == fontDirectory) {
         return;
     }
 
     for (struct dirent* dirEntry; (dirEntry = readdir(fontDirectory));) {
-        // The size of both the prefix, suffix, and a minimum valid language code
-        static const size_t minSize = sizeof(LOCALE_FALLBACK_FONTS_PREFIX) - 1
-                                    + sizeof(LOCALE_FALLBACK_FONTS_SUFFIX) - 1
-                                    + 2;
+        // The size of the prefix and suffix.
+        static const size_t fixedLen = sizeof(LOCALE_FALLBACK_FONTS_PREFIX) - 1
+                                     + sizeof(LOCALE_FALLBACK_FONTS_SUFFIX) - 1;
+
+        // The size of the prefix, suffix, and a minimum valid language code
+        static const size_t minSize = fixedLen + 2;
 
         SkString fileName(dirEntry->d_name);
         if (fileName.size() < minSize ||
             !fileName.startsWith(LOCALE_FALLBACK_FONTS_PREFIX) ||
             !fileName.endsWith(LOCALE_FALLBACK_FONTS_SUFFIX))
         {
             continue;
         }
 
-        static const size_t fixedLen = sizeof(LOCALE_FALLBACK_FONTS_PREFIX) - 1
-                                     + sizeof(LOCALE_FALLBACK_FONTS_SUFFIX) - 1;
-
         SkString locale(fileName.c_str() + sizeof(LOCALE_FALLBACK_FONTS_PREFIX) - 1,
                         fileName.size() - fixedLen);
 
         SkString absoluteFilename;
         absoluteFilename.printf("%s/%s", dir, fileName.c_str());
 
         SkTDArray<FontFamily*> langSpecificFonts;
         parse_config_file(absoluteFilename.c_str(), langSpecificFonts, basePath, true);
 
         for (int i = 0; i < langSpecificFonts.count(); ++i) {
@@ skipping 86 matching lines @@
     const char* tag = fTag.c_str();
 
     // strip off the rightmost "-.*"
     const char* parentTagEnd = strrchr(tag, '-');
     if (parentTagEnd == NULL) {
         return SkLanguage();
     }
     size_t parentTagLen = parentTagEnd - tag;
     return SkLanguage(tag, parentTagLen);
 }