Verify all parsed test font files start with cap.

Verify all parsed test font files start with cap.

All of the Android test font configuration files have file names which
start with a capital latin letter. Verify this is true of the parsed file
names. This would have caught previous issues with slicing, and will
hopefully prevent such issues going unnoticed in the future.

Committed: https://skia.googlesource.com/skia/+/9a0808fd8e83128403285f391944850d908d7af0

[bungeman-skia, 2015-02-13 16:08:05]

bungeman@google.com changed reviewers:
+ djsollen@google.com

[bungeman-skia, 2015-02-13 16:08:05]

This is the test promised on https://codereview.chromium.org/887113002/ for the
issue fixed at
https://codereview.chromium.org/887113002/diff2/100001:120001/src/ports/SkFon...
.

[djsollen, 2015-02-13 16:17:50]

lgtm if you update the comment.

https://codereview.chromium.org/925933003/diff/1/tests/FontConfigParser.cpp
File tests/FontConfigParser.cpp (right):

https://codereview.chromium.org/925933003/diff/1/tests/FontConfigParser.cpp#n...
tests/FontConfigParser.cpp:52: // All file names in the test configuration files
start with a capital letter.
comment that this isn't a requirement, but since it currently holds true it
allows us to ensure that we correctly decode the names.

[bungeman-skia, 2015-02-13 16:37:05]

New patchsets have been uploaded after l-g-t-m from djsollen@google.com

[bungeman-skia, 2015-02-13 16:38:07]

https://codereview.chromium.org/925933003/diff/1/tests/FontConfigParser.cpp
File tests/FontConfigParser.cpp (right):

https://codereview.chromium.org/925933003/diff/1/tests/FontConfigParser.cpp#n...
tests/FontConfigParser.cpp:52: // All file names in the test configuration files
start with a capital letter.
On 2015/02/13 16:17:49, djsollen wrote:
> comment that this isn't a requirement, but since it currently holds true it
> allows us to ensure that we correctly decode the names.

Done.

[bungeman-skia, 2015-02-13 16:40:46]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-02-13 16:41:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/925933003/20001

[commit-bot: I haz the power, 2015-02-13 16:55:21]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9a0808fd8e83128403285f391944850d908d7af0