Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 925923003: Update BrowserAccessibilityManager to support Lollipop SDK. (Closed)

Created:
5 years, 10 months ago by dmazzoni
Modified:
5 years, 10 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@hover_debug
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update BrowserAccessibilityManager to support Lollipop SDK. Renames KitKatBrowserAccessibilityManager to LollipopBrowserAccessibilityManager because we were never able to use the KitKat variant due to KitKat framework bugs. Adds a new method specifically for adding actions to AccessibilityNodeInfo, so we can use the new API in Lollipop, and suppresses the deprecation warnings in the non-Lollipop implementation. This gets rid of all of the remaining deprecation warnings in content/. BUG=405174 Committed: https://crrev.com/9ce3a2076eb4b295e9d9d4aa0660c0a8bb103242 Cr-Commit-Position: refs/heads/master@{#316293}

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
dmazzoni
5 years, 10 months ago (2015-02-13 18:43:11 UTC) #2
newt (away)
drive-by woohoo! Thanks for cleaning this up :)
5 years, 10 months ago (2015-02-13 18:48:08 UTC) #4
aurimas (slooooooooow)
lgtm
5 years, 10 months ago (2015-02-13 18:56:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925923003/1
5 years, 10 months ago (2015-02-13 20:02:32 UTC) #7
aurimas (slooooooooow)
You need an LGTM for an OWNER. +dtrainor
5 years, 10 months ago (2015-02-13 20:04:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 21:33:26 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 21:34:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ce3a2076eb4b295e9d9d4aa0660c0a8bb103242
Cr-Commit-Position: refs/heads/master@{#316293}

Powered by Google App Engine
This is Rietveld 408576698