Fixed WebDragData's wrong dependency.

Fixed WebDragData's wrong dependency.
    
WebDragData is placed in public/platform, but its code is placed in Source/web.
WebDragData should be placed in Source/platform/exported and should not depend on core.

- since WebDragData depends on core and modules, modify DraggedIsolatedFileSystem, 
  i.e. DraggedIsolatedFileSystemImpl in modules and DraggedIsolatedFileSystem in core.
  InitModules initializes core for DraggedIsolatedFileSystemImpl in modules.
- WebDragData depends on "initialized" or not (content uses).
  Added m_valid to see whether "initialized" or not.

BUG=358074
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191174

[tasak, 2015-02-16 10:24:50]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[tasak, 2015-02-16 10:24:51]

PTAL?

[tasak, 2015-02-16 11:08:54]

On 2015/02/16 10:24:51, tasak wrote:
> PTAL?

We need to fix 11 Web files:
diff --git a/public/platform/WebDragData.h b/public/platform/WebDragData.h
diff --git a/public/platform/WebEncryptedMediaRequest.h
b/public/platform/WebEncryptedMediaRequest.h
diff --git a/public/platform/WebIDBDatabaseError.h
b/public/platform/WebIDBDatabaseError.h
diff --git a/public/platform/WebIDBKey.h b/public/platform/WebIDBKey.h
diff --git a/public/platform/WebIDBKeyPath.h b/public/platform/WebIDBKeyPath.h
diff --git a/public/platform/WebIDBKeyRange.h b/public/platform/WebIDBKeyRange.h
diff --git a/public/platform/WebIDBMetadata.h b/public/platform/WebIDBMetadata.h
diff --git a/public/platform/WebMessagePortChannelClient.h
b/public/platform/WebMessagePortChannelClient.h
diff --git a/public/platform/WebScrollbarThemePainter.h
b/public/platform/WebScrollbarThemePainter.h
diff --git a/public/platform/WebThreadedDataReceiver.h
b/public/platform/WebThreadedDataReceiver.h
diff --git a/public/platform/WebWorkerRunLoop.h
b/public/platform/WebWorkerRunLoop.h

[haraken, 2015-02-16 12:15:44]

On 2015/02/16 11:08:54, tasak wrote:
> On 2015/02/16 10:24:51, tasak wrote:
> > PTAL?
> 
> We need to fix 11 Web files:
> diff --git a/public/platform/WebDragData.h b/public/platform/WebDragData.h
> diff --git a/public/platform/WebEncryptedMediaRequest.h
> b/public/platform/WebEncryptedMediaRequest.h
> diff --git a/public/platform/WebIDBDatabaseError.h
> b/public/platform/WebIDBDatabaseError.h
> diff --git a/public/platform/WebIDBKey.h b/public/platform/WebIDBKey.h
> diff --git a/public/platform/WebIDBKeyPath.h b/public/platform/WebIDBKeyPath.h
> diff --git a/public/platform/WebIDBKeyRange.h
b/public/platform/WebIDBKeyRange.h
> diff --git a/public/platform/WebIDBMetadata.h
b/public/platform/WebIDBMetadata.h
> diff --git a/public/platform/WebMessagePortChannelClient.h
> b/public/platform/WebMessagePortChannelClient.h
> diff --git a/public/platform/WebScrollbarThemePainter.h
> b/public/platform/WebScrollbarThemePainter.h
> diff --git a/public/platform/WebThreadedDataReceiver.h
> b/public/platform/WebThreadedDataReceiver.h
> diff --git a/public/platform/WebWorkerRunLoop.h
> b/public/platform/WebWorkerRunLoop.h

Thanks for the list!

Let's discuss this offline tomorrow. I understand what you're doing but I'm not
fully convinced this is the best work-around.

[haraken, 2015-02-17 12:35:28]

Discussed offline. The inlining hack is nasty and we need a better integration
between content, web and core/modules. However, it seems better to revisit the
issue after repository merge.

LGTM.

[tasak, 2015-02-18 01:53:32]

tasak@google.com changed reviewers:
+ tkent@chromium.org

[tasak, 2015-02-18 01:53:33]

tkent, would you review this CL?

[tkent, 2015-02-18 02:17:57]

https://codereview.chromium.org/925913002/diff/20001/public/platform/WebDragD...
File public/platform/WebDragData.h (right):

https://codereview.chromium.org/925913002/diff/20001/public/platform/WebDragD...
public/platform/WebDragData.h:117: // FIXME: to avoid "core depends on web", use
inline here.
The problem is "platform depends on core", not "core depends on web".
We should do:

- Remove DataObject dependency from WebDragData.
  Now WebDragData is a wrapper of DataObject.  We should change it so that
WebDragData contains real data.

- Move WebDragData.cpp from Source/web/ to Source/platform/exported/.

[tkent, 2015-02-18 02:20:22]

Repository merge improves nothing about this issue.

[tasak, 2015-02-19 04:20:06]

New patchsets have been uploaded after l-g-t-m from haraken@chromium.org

[tasak, 2015-02-23 06:17:15]

Patchset #4 (id:60001) has been deleted

[tasak, 2015-02-23 06:18:08]

Patchset #3 (id:40001) has been deleted

[tasak, 2015-02-23 09:20:33]

Thank you for review.

I moved WebDragData from Source/web to Source/platform/exported:

- since WebDragData depends on core and modules, modify
DraggedIsolatedFileSystem, i.e. DraggedIsolatedFileSystemImpl in modules and
DraggedIsolatedFileSystem in core.
  InitModules initializes core for DraggedIsolatedFileSystemImpl in modules.
- WebDragData depends on "initialized" or not (content uses). Added m_valid to
see whether "initialized" or not.

> Repository merge improves nothing about this issue.

I think, merge doesn't directly help us. However, it would make it easier for us
to change public/platform interfaces.

https://codereview.chromium.org/925913002/diff/20001/public/platform/WebDragD...
File public/platform/WebDragData.h (right):

https://codereview.chromium.org/925913002/diff/20001/public/platform/WebDragD...
public/platform/WebDragData.h:117: // FIXME: to avoid "core depends on web", use
inline here.
On 2015/02/18 02:17:57, tkent wrote:
> The problem is "platform depends on core", not "core depends on web".
> We should do:
> 
> - Remove DataObject dependency from WebDragData.
>   Now WebDragData is a wrapper of DataObject.  We should change it so that
> WebDragData contains real data.
> 
> - Move WebDragData.cpp from Source/web/ to Source/platform/exported/.

Done.

[dcheng, 2015-02-23 16:19:51]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-02-23 16:19:52]

https://codereview.chromium.org/925913002/diff/80001/Source/platform/exported...
File Source/platform/exported/WebDragData.cpp (right):

https://codereview.chromium.org/925913002/diff/80001/Source/platform/exported...
Source/platform/exported/WebDragData.cpp:39: m_itemList = itemList;
Using swap() would be nice here, but I don't know how we would expose that
cleanly.

Maybe WebDragData can friend DataObject, so DataObject can reach in directly to
swap the items?

https://codereview.chromium.org/925913002/diff/80001/Source/platform/exported...
Source/platform/exported/WebDragData.cpp:50: m_itemList = itemList;
Use swap() instead of assigning? This is going to copy everything.

[tkent, 2015-02-23 23:40:41]

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Da...
File Source/core/clipboard/DataObject.h (right):

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Da...
Source/core/clipboard/DataObject.h:101: static
PassRefPtrWillBeRawPtr<DataObject> createFromWebDragData(WebDragData);
We can call this |create|.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
File Source/core/clipboard/DraggedIsolatedFileSystem.cpp (right):

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.cpp:1: #include "config.h"
Add the 3-line copyright header.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
File Source/core/clipboard/DraggedIsolatedFileSystem.h (right):

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.h:1: /*
If this is not a copy of existing file, please use the 3-line copyright header.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.h:38: #include
"wtf/text/WTFString.h"
This is unnecessary because this file includes wtf/Forward.h.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.h:48: static void init(void
(*)(DataObject*, const String&));
I recommend to add |using fileSystemIdPreparationCallback = void
(*)(DataObject&, const String&);|

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.h:52: static void
(*m_prepareMethod)(DataObject*, const String&);
m_prepareMethod -> s_prepareCallback

'method' usually means 'member function'.  This function is not limited to a
member.

https://codereview.chromium.org/925913002/diff/80001/Source/web/web.gypi
File Source/web/web.gypi (right):

https://codereview.chromium.org/925913002/diff/80001/Source/web/web.gypi#newc...
Source/web/web.gypi:143: #     'WebDragData.cpp',
Remove this line.

[tasak, 2015-02-25 08:15:25]

Thank you for review.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Da...
File Source/core/clipboard/DataObject.h (right):

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Da...
Source/core/clipboard/DataObject.h:101: static
PassRefPtrWillBeRawPtr<DataObject> createFromWebDragData(WebDragData);
On 2015/02/23 23:40:40, tkent wrote:
> We can call this |create|.

Done.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
File Source/core/clipboard/DraggedIsolatedFileSystem.cpp (right):

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.cpp:1: #include "config.h"
On 2015/02/23 23:40:40, tkent wrote:
> Add the 3-line copyright header.

Done.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
File Source/core/clipboard/DraggedIsolatedFileSystem.h (right):

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.h:1: /*
On 2015/02/23 23:40:41, tkent wrote:
> If this is not a copy of existing file, please use the 3-line copyright
header.

Done.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.h:38: #include
"wtf/text/WTFString.h"
On 2015/02/23 23:40:41, tkent wrote:
> This is unnecessary because this file includes wtf/Forward.h.

Done.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.h:48: static void init(void
(*)(DataObject*, const String&));
On 2015/02/23 23:40:41, tkent wrote:
> I recommend to add |using fileSystemIdPreparationCallback = void
> (*)(DataObject&, const String&);|
> 
> 

Done.

https://codereview.chromium.org/925913002/diff/80001/Source/core/clipboard/Dr...
Source/core/clipboard/DraggedIsolatedFileSystem.h:52: static void
(*m_prepareMethod)(DataObject*, const String&);
On 2015/02/23 23:40:41, tkent wrote:
> m_prepareMethod -> s_prepareCallback
> 
> 'method' usually means 'member function'.  This function is not limited to a
> member.
> 

Done.

https://codereview.chromium.org/925913002/diff/80001/Source/platform/exported...
File Source/platform/exported/WebDragData.cpp (right):

https://codereview.chromium.org/925913002/diff/80001/Source/platform/exported...
Source/platform/exported/WebDragData.cpp:39: m_itemList = itemList;
On 2015/02/23 16:19:52, dcheng wrote:
> Using swap() would be nice here, but I don't know how we would expose that
> cleanly.
> 
> Maybe WebDragData can friend DataObject, so DataObject can reach in directly
to
> swap the items?

Done.

https://codereview.chromium.org/925913002/diff/80001/Source/platform/exported...
Source/platform/exported/WebDragData.cpp:50: m_itemList = itemList;
On 2015/02/23 16:19:52, dcheng wrote:
> Use swap() instead of assigning? This is going to copy everything.

Done.

https://codereview.chromium.org/925913002/diff/80001/Source/web/web.gypi
File Source/web/web.gypi (right):

https://codereview.chromium.org/925913002/diff/80001/Source/web/web.gypi#newc...
Source/web/web.gypi:143: #     'WebDragData.cpp',
On 2015/02/23 23:40:41, tkent wrote:
> Remove this line.

Done.

[tkent, 2015-02-25 08:27:17]

lgtm

https://codereview.chromium.org/925913002/diff/100001/Source/core/clipboard/D...
File Source/core/clipboard/DraggedIsolatedFileSystem.h (right):

https://codereview.chromium.org/925913002/diff/100001/Source/core/clipboard/D...
Source/core/clipboard/DraggedIsolatedFileSystem.h:21: using
fileSystemIdPreparationCallback = void(*)(DataObject*, const String&);
fileSystem -> FileSystem
A type name should start with a capital letter.  My suggestion was wrong :-)

https://codereview.chromium.org/925913002/diff/100001/Source/core/clipboard/D...
Source/core/clipboard/DraggedIsolatedFileSystem.h:27: static
fileSystemIdPreparationCallback m_prepareCallback;
m_prepareCallback -> s_prepareCallback

[dcheng, 2015-02-25 15:37:00]

https://codereview.chromium.org/925913002/diff/100001/Source/platform/exporte...
File Source/platform/exported/WebDragData.cpp (right):

https://codereview.chromium.org/925913002/diff/100001/Source/platform/exporte...
Source/platform/exported/WebDragData.cpp:36: void
WebDragData::setItems(WebVector<Item> itemList)
You don't save a copy by doing this--you still end up copying the contents of
the WebVector by calling this function.

Since this function is only needed by DataObject, that's why I suggested
friending it and just having it swap the items directly.

[tasak, 2015-02-26 11:27:48]

Thank you for review.

https://codereview.chromium.org/925913002/diff/100001/Source/core/clipboard/D...
File Source/core/clipboard/DraggedIsolatedFileSystem.h (right):

https://codereview.chromium.org/925913002/diff/100001/Source/core/clipboard/D...
Source/core/clipboard/DraggedIsolatedFileSystem.h:21: using
fileSystemIdPreparationCallback = void(*)(DataObject*, const String&);
On 2015/02/25 08:27:17, tkent wrote:
> fileSystem -> FileSystem
> A type name should start with a capital letter.  My suggestion was wrong :-)
> 

Done.

https://codereview.chromium.org/925913002/diff/100001/Source/core/clipboard/D...
Source/core/clipboard/DraggedIsolatedFileSystem.h:27: static
fileSystemIdPreparationCallback m_prepareCallback;
On 2015/02/25 08:27:17, tkent wrote:
> m_prepareCallback -> s_prepareCallback

Done.

https://codereview.chromium.org/925913002/diff/100001/Source/platform/exporte...
File Source/platform/exported/WebDragData.cpp (right):

https://codereview.chromium.org/925913002/diff/100001/Source/platform/exporte...
Source/platform/exported/WebDragData.cpp:36: void
WebDragData::setItems(WebVector<Item> itemList)
On 2015/02/25 15:37:00, dcheng wrote:

> Since this function is only needed by DataObject, that's why I suggested
> friending it and just having it swap the items directly.

//content/renderer/render_view_impl.cc also uses setItems.
Since the code uses std::vector<WebDragData::Item>, I cannot use
WebVector<Item>& here.

So I added setItemsFast for blink. I will fix render_view_impl.cc later.

[dcheng, 2015-02-27 16:53:03]

lgtm

https://codereview.chromium.org/925913002/diff/100001/Source/platform/exporte...
File Source/platform/exported/WebDragData.cpp (right):

https://codereview.chromium.org/925913002/diff/100001/Source/platform/exporte...
Source/platform/exported/WebDragData.cpp:36: void
WebDragData::setItems(WebVector<Item> itemList)
On 2015/02/26 11:27:48, tasak wrote:
> On 2015/02/25 15:37:00, dcheng wrote:
> 
> > Since this function is only needed by DataObject, that's why I suggested
> > friending it and just having it swap the items directly.
> 
> //content/renderer/render_view_impl.cc also uses setItems.
> Since the code uses std::vector<WebDragData::Item>, I cannot use
> WebVector<Item>& here.
> 
> So I added setItemsFast for blink. I will fix render_view_impl.cc later.
> 
> 
> 

Ah, I forgot about that.

Maybe just call it swapItems(), since that's what it does.

[tasak, 2015-03-03 05:43:10]

Thank you for review.

[tasak, 2015-03-03 05:43:15]

The CQ bit was checked by tasak@google.com

[tasak, 2015-03-03 05:43:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tkent@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/925913002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-03-03 05:43:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/925913002/140001

[commit-bot: I haz the power, 2015-03-03 07:07:13]

Committed patchset #6 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191174