Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 925903006: Refactor debug_daemon_client.h to use debugd::DevFeatureFlag (Closed)

Created:
5 years, 10 months ago by xc
Modified:
5 years, 10 months ago
Reviewers:
xiyuan, stevenjb
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor debug_daemon_client.h to use debugd::DevFeatureFlag debug_daemon_client.h used to define its own duplicate enum. This cl unifies it to use the enum defined in debugd. BUG=444146 TEST=locally on chromebook. Committed: https://crrev.com/4b5aef62bbbf566031efd57921bf2a5ef5498cef Cr-Commit-Position: refs/heads/master@{#316607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M chrome/browser/chromeos/login/enable_debugging_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.h View 2 chunks +9 lines, -17 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_debug_daemon_client.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xc
5 years, 10 months ago (2015-02-13 20:33:08 UTC) #2
xiyuan
lgtm
5 years, 10 months ago (2015-02-13 20:59:04 UTC) #3
xc
Need owner's review.
5 years, 10 months ago (2015-02-13 22:01:44 UTC) #5
stevenjb
owner lgtm
5 years, 10 months ago (2015-02-13 23:39:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925903006/1
5 years, 10 months ago (2015-02-17 17:40:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 18:04:57 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:05:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b5aef62bbbf566031efd57921bf2a5ef5498cef
Cr-Commit-Position: refs/heads/master@{#316607}

Powered by Google App Engine
This is Rietveld 408576698