Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 925873005: Add TypeChecking=Unrestricted to SVGPathSeg interfaces and "constructors" (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
CC:
arv+blink, blink-reviews, Inactive, krit, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add TypeChecking=Unrestricted to SVGPathSeg interfaces and "constructors" "constructors" are the SVGPathElement.createSVGPathSeg* functions. These methods have low usage, and this matches Geckos behavior. BUG=354298, 311246 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -19 lines) Patch
A LayoutTests/svg/dom/SVGPathSeg-construction.html View 1 chunk +69 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegArcRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
fs
5 years, 10 months ago (2015-02-13 16:12:10 UTC) #2
Jens Widell
Thanks for working on this!
5 years, 10 months ago (2015-02-13 16:32:41 UTC) #3
pdr.
LGTM, just in time for the SVGPathSeg deprecation! :)
5 years, 10 months ago (2015-02-13 22:48:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925873005/1
5 years, 10 months ago (2015-02-13 22:48:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190173
5 years, 10 months ago (2015-02-13 22:52:17 UTC) #7
kouhei (in TOK)
lgtm. Just to confirm: This CL allows methods defined in those interfaces to allow "+-Inf" ...
5 years, 10 months ago (2015-02-16 05:06:35 UTC) #8
fs
On 2015/02/16 05:06:35, kouhei wrote: > lgtm. > > Just to confirm: This CL allows ...
5 years, 10 months ago (2015-02-16 09:09:26 UTC) #9
kouhei (in TOK)
5 years, 10 months ago (2015-02-16 10:15:40 UTC) #10
Message was sent while issue was closed.
On 2015/02/16 09:09:26, fs wrote:
> On 2015/02/16 05:06:35, kouhei wrote:
> > lgtm.
> > 
> > Just to confirm: This CL allows methods defined in those interfaces to allow
> > "+-Inf" values, and the CL isn't related to SVGPathSeg deprecation. Is this
> > correct?
> 
> Calling SVGPathElement.createSVGPathSeg* or setting any (float) attribute on
> SVGPathSeg* to NaN/+/-Inf will now throw a TypeError. That it happened to
occur
> around the same time as the deprecation is merely due to coincidence. (One
could
> say that there was a weak connection though...)

Thanks for the clarification!

Powered by Google App Engine
This is Rietveld 408576698