Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 925873002: Fix a queue for FSP API. (Closed)

Created:
5 years, 10 months ago by mtomasz
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a queue for FSP API. Due to a bug the queue was running more tasks than maximum capacity of the queue. That made the browser tests flaky. Unfortunatley this case wasn't covered by unit tests. This CL adds it. TEST=None BUG=None Committed: https://crrev.com/8b9dcdb4c5cf8babb1f8df0ccfe4a610d9b4a6f8 Cr-Commit-Position: refs/heads/master@{#316191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M chrome/browser/chromeos/file_system_provider/queue.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/queue_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 10 months ago (2015-02-13 08:13:32 UTC) #2
hirono
sorry for missing this. lgtm!
5 years, 10 months ago (2015-02-13 08:16:14 UTC) #3
mtomasz
On 2015/02/13 08:16:14, hirono wrote: > sorry for missing this. lgtm! np, thanks!
5 years, 10 months ago (2015-02-13 08:16:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925873002/1
5 years, 10 months ago (2015-02-13 08:17:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 08:35:56 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 08:36:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b9dcdb4c5cf8babb1f8df0ccfe4a610d9b4a6f8
Cr-Commit-Position: refs/heads/master@{#316191}

Powered by Google App Engine
This is Rietveld 408576698