Issue 925853002: Make SkImage::getTexture() const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 925853002: Make SkImage::getTexture() const (Closed)

Created:
5 years, 10 months ago by Kimmo Kinnunen

Modified:
5 years, 10 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Make SkImage::getTexture() const Make SkImage::getTexture() const. At the moment the function does not mutate the state. One use-case is that this makes it possible in the future to add draw function to SkBaseDevice functions. The device draw functions take const ref objects, but SkGpuDevice likely would benefit of using the getTexture(). BUG=skia:3388 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/cd6ca9e689610d9fad2ef2b9c840dcdccc649471

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	include/core/SkImage.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/image/SkImage.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925853002/1

5 years, 10 months ago (2015-02-18 14:45:44 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-18 18:50:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cd6ca9e689610d9fad2ef2b9c840dcdccc649471

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages