Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2091)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/api/printer_provider/printer_provider_api.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/json/json_value_serializer_unittest.cc ('K') | « components/update_client/component_unpacker.cc ('k') | extensions/common/extension_l10n_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/printer_provider/printer_provider_api.cc
diff --git a/extensions/browser/api/printer_provider/printer_provider_api.cc b/extensions/browser/api/printer_provider/printer_provider_api.cc
index da66224ae389f20db920bca627fefba0d88a3a11..4cd75dfe93419892c79025725f5dbae4c9f7a31c 100644
--- a/extensions/browser/api/printer_provider/printer_provider_api.cc
+++ b/extensions/browser/api/printer_provider/printer_provider_api.cc
@@ -173,8 +173,8 @@ void PrinterProviderAPI::DispatchPrintRequested(
core_api::printer_provider::PrintJob print_job;
print_job.printer_id = internal_printer_id;
- JSONStringValueSerializer serializer(job.ticket_json);
- scoped_ptr<base::Value> ticket_value(serializer.Deserialize(NULL, NULL));
+ JSONStringValueDeserializer deserializer(job.ticket_json);
+ scoped_ptr<base::Value> ticket_value(deserializer.Deserialize(NULL, NULL));
if (!ticket_value ||
!core_api::printer_provider::PrintJob::Ticket::Populate(
*ticket_value, &print_job.ticket)) {
« base/json/json_value_serializer_unittest.cc ('K') | « components/update_client/component_unpacker.cc ('k') | extensions/common/extension_l10n_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698