chrome/browser/ui/app_list/start_page_service.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/start_page_service.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/json/json_value_serializer_unittest.cc ('K') | « chrome/browser/supervised_user/supervised_user_site_list.cc ('k') | chrome/browser/ui/webui/nacl_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/start_page_service.cc

diff --git a/chrome/browser/ui/app_list/start_page_service.cc b/chrome/browser/ui/app_list/start_page_service.cc

index 4df7bbbd343d0e53d48a4f01c8f3e60feca31bb9..0a659340f6a7dc911b41c3d8dd2a87ae8a1bff37 100644

--- a/chrome/browser/ui/app_list/start_page_service.cc

+++ b/chrome/browser/ui/app_list/start_page_service.cc

@@ -637,7 +637,7 @@ void StartPageService::OnURLFetchComplete(const net::URLFetcher* source) {

if (json_start_index != std::string::npos)

json_data_substr.remove_prefix(json_start_index);

- JSONStringValueSerializer deserializer(json_data_substr);

+ JSONStringValueDeserializer deserializer(json_data_substr);

deserializer.set_allow_trailing_comma(true);

int error_code = 0;

scoped_ptr<base::Value> doodle_json(