extensions/common/extension_l10n_util.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_l10n_util.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/extension_l10n_util.cc

diff --git a/extensions/common/extension_l10n_util.cc b/extensions/common/extension_l10n_util.cc

index e60e2ec726b27564cbd3a96f0a9bdc0f85febe3e..dbdd5d9e768b862dc4acd412d71bc47cfffd2a0e 100644

--- a/extensions/common/extension_l10n_util.cc

+++ b/extensions/common/extension_l10n_util.cc

@@ -38,8 +38,8 @@ base::DictionaryValue* LoadMessageFile(const base::FilePath& locale_path,

std::string* error) {

base::FilePath file =

locale_path.AppendASCII(locale).Append(extensions::kMessagesFilename);

- JSONFileValueSerializer messages_serializer(file);

- base::Value* dictionary = messages_serializer.Deserialize(NULL, error);

+ JSONFileValueDeserializer messages_deserializer(file);

+ base::Value* dictionary = messages_deserializer.Deserialize(NULL, error);

if (!dictionary) {

if (error->empty()) {

// JSONFileValueSerializer just returns NULL if file cannot be found. It

« no previous file with comments | « extensions/browser/image_loader_unittest.cc ('k') | extensions/common/file_util.cc » ('j') | no next file with comments »