components/update_client/component_patcher.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/component_patcher.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/update_client/component_patcher.cc

diff --git a/components/update_client/component_patcher.cc b/components/update_client/component_patcher.cc

index 3077bc4f40b5a24ebe1f8a7ca71a87d285862c79..29ce7747d9b8a9b15661fb64c985eb0ae74271bc 100644

--- a/components/update_client/component_patcher.cc

+++ b/components/update_client/component_patcher.cc

@@ -30,8 +30,8 @@ base::ListValue* ReadCommands(const base::FilePath& unpack_path) {

if (!base::PathExists(commands))

return NULL;

- JSONFileValueSerializer serializer(commands);

- scoped_ptr<base::Value> root(serializer.Deserialize(NULL, NULL));

+ JSONFileValueDeserializer deserializer(commands);

+ scoped_ptr<base::Value> root(deserializer.Deserialize(NULL, NULL));

return (root.get() && root->IsType(base::Value::TYPE_LIST))

? static_cast<base::ListValue*>(root.release())

« no previous file with comments | « components/policy/core/common/config_dir_policy_loader.cc ('k') | components/update_client/component_unpacker.cc » ('j') | no next file with comments »