components/bookmarks/browser/bookmark_codec_unittest.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_codec_unittest.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/bookmarks/browser/bookmark_codec_unittest.cc

diff --git a/components/bookmarks/browser/bookmark_codec_unittest.cc b/components/bookmarks/browser/bookmark_codec_unittest.cc

index 9d529f84e4dc4bb4114f31f2b756a6d823f93dfb..8c45aea87f0ff9cc785df6e12205c83c5ce88434 100644

--- a/components/bookmarks/browser/bookmark_codec_unittest.cc

+++ b/components/bookmarks/browser/bookmark_codec_unittest.cc

@@ -359,8 +359,8 @@ TEST_F(BookmarkCodecTest, CanDecodeModelWithoutMobileBookmarks) {

GetTestDataDir().AppendASCII("bookmarks/model_without_sync.json");

ASSERT_TRUE(base::PathExists(test_file));

- JSONFileValueSerializer serializer(test_file);

- scoped_ptr<base::Value> root(serializer.Deserialize(NULL, NULL));

+ JSONFileValueDeserializer deserializer(test_file);

+ scoped_ptr<base::Value> root(deserializer.Deserialize(NULL, NULL));

scoped_ptr<BookmarkModel> decoded_model(client_.CreateModel());

BookmarkCodec decoder;

@@ -445,8 +445,8 @@ TEST_F(BookmarkCodecTest, CanDecodeMetaInfoAsString) {

GetTestDataDir().AppendASCII("bookmarks/meta_info_as_string.json");