chrome/installer/util/uninstall_metrics_unittest.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/uninstall_metrics_unittest.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/uninstall_metrics_unittest.cc

diff --git a/chrome/installer/util/uninstall_metrics_unittest.cc b/chrome/installer/util/uninstall_metrics_unittest.cc

index 621b0dbb95057f10dc14f28bc919f37abe64e94a..aa0ff15c240b2f43cd52bc21d266ba7a6fd02b87 100644

--- a/chrome/installer/util/uninstall_metrics_unittest.cc

+++ b/chrome/installer/util/uninstall_metrics_unittest.cc

@@ -43,7 +43,7 @@ TEST(UninstallMetricsTest, TestExtractUninstallMetrics) {

L"&launch_count=11&page_load_count=68"

L"&uptime_sec=809");

- JSONStringValueSerializer json_deserializer(pref_string);

+ JSONStringValueDeserializer json_deserializer(pref_string);

std::string error_message;

scoped_ptr<base::Value> root(

« no previous file with comments | « chrome/installer/util/uninstall_metrics.cc ('k') | chrome/utility/importer/firefox_importer.cc » ('j') | no next file with comments »