chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc b/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

index 7fb2c964c51de848ccdb941f332ff4b94adb5c09..785b2a63524f60aa708a10d1658cb52c24f3506a 100644

--- a/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

+++ b/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

@@ -165,7 +165,7 @@ void RecordPrintResult(size_t* call_count,

scoped_ptr<base::ListValue> GetJSONAsListValue(const std::string& json,

std::string* error) {

scoped_ptr<base::Value> deserialized(

- JSONStringValueSerializer(json).Deserialize(NULL, error));

+ JSONStringValueDeserializer(json).Deserialize(NULL, error));

if (!deserialized)

return scoped_ptr<base::ListValue>();

base::ListValue* list = nullptr;

@@ -182,7 +182,7 @@ scoped_ptr<base::DictionaryValue> GetJSONAsDictionaryValue(

const std::string& json,

std::string* error) {

scoped_ptr<base::Value> deserialized(

- JSONStringValueSerializer(json).Deserialize(NULL, error));

+ JSONStringValueDeserializer(json).Deserialize(NULL, error));

if (!deserialized)

return scoped_ptr<base::DictionaryValue>();

base::DictionaryValue* dictionary;

« no previous file with comments | « chrome/browser/ui/webui/nacl_ui.cc ('k') | chrome/common/extensions/extension_test_util.cc » ('j') | no next file with comments »