chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc ('k') | chrome/browser/component_updater/pnacl/pnacl_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc b/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

index bd65b300708fca18dd4292b7176872b41eb6f481..c2ea24d4849c68890009e7a1f89542feae12c5b9 100644

--- a/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

+++ b/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

@@ -55,12 +55,13 @@ std::string BuildRawHMACKey() {

}

base::DictionaryValue* LoadPasswordData(base::FilePath profile_dir) {

- JSONFileValueSerializer serializer(profile_dir.Append(kPasswordUpdateFile));

+ JSONFileValueDeserializer deserializer(

+ profile_dir.Append(kPasswordUpdateFile));

std::string error_message;

- int error_code = JSONFileValueSerializer::JSON_NO_ERROR;

+ int error_code = JSONFileValueDeserializer::JSON_NO_ERROR;

scoped_ptr<base::Value> value(

- serializer.Deserialize(&error_code, &error_message));

- if (JSONFileValueSerializer::JSON_NO_ERROR != error_code) {

+ deserializer.Deserialize(&error_code, &error_message));

+ if (JSONFileValueDeserializer::JSON_NO_ERROR != error_code) {

LOG(ERROR) << "Could not deserialize password data, error = " << error_code

<< " / " << error_message;

return NULL;