Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comment. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/component_loader.cc
diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc
index 2ee48167a4bf1d1f95db2d82d0818b884ecc8c15..8b4101211da10af3a584f46eeda9f5070858ca8e 100644
--- a/chrome/browser/extensions/component_loader.cc
+++ b/chrome/browser/extensions/component_loader.cc
@@ -138,8 +138,8 @@ void ComponentLoader::LoadAll() {
base::DictionaryValue* ComponentLoader::ParseManifest(
const std::string& manifest_contents) const {
- JSONStringValueSerializer serializer(manifest_contents);
- scoped_ptr<base::Value> manifest(serializer.Deserialize(NULL, NULL));
+ JSONStringValueDeserializer deserializer(manifest_contents);
+ scoped_ptr<base::Value> manifest(deserializer.Deserialize(NULL, NULL));
if (!manifest.get() || !manifest->IsType(base::Value::TYPE_DICTIONARY)) {
LOG(ERROR) << "Failed to parse extension manifest.";

Powered by Google App Engine
This is Rietveld 408576698