Issue 925763003: Fix pdfium_test build inside Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 925763003: Fix pdfium_test build inside Chromium. (Closed)

Created:
5 years, 10 months ago by jam

Modified:
5 years, 10 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	samples/BUILD.gn	View	1	3 chunks	+10 lines, -0 lines	0 comments	Download
	M	samples/samples.gyp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

jam

When this is built inside Chromium, build/common.gypi is somehow bringing in system or src/third_party libpng ...

5 years, 10 months ago (2015-02-13 06:14:51 UTC) #2

jam

5 years, 10 months ago (2015-02-17 21:26:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ca6c0d3262d994fbb008ee1ae5ff19c1612bc982 (presubmit successful).