Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: tools/metrics/rappor/PRESUBMIT.py

Issue 925753002: Add pretty printing for rappor.xml (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/metrics/rappor/OWNERS ('k') | tools/metrics/rappor/pretty_print.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/rappor/PRESUBMIT.py
diff --git a/tools/metrics/actions/PRESUBMIT.py b/tools/metrics/rappor/PRESUBMIT.py
similarity index 61%
copy from tools/metrics/actions/PRESUBMIT.py
copy to tools/metrics/rappor/PRESUBMIT.py
index c5d1e8e721e0c9ac41ddfe4554465abadda73616..c70f50fe7a6943718ec19e6ffcffb0bda2e27539 100644
--- a/tools/metrics/actions/PRESUBMIT.py
+++ b/tools/metrics/rappor/PRESUBMIT.py
@@ -1,27 +1,27 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
+# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Presubmit script for actions.xml.
+"""Presubmit script for rappor.xml.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
-for more details on the presubmit API built into depot_tools.
+for more details on the presubmit API built into gcl.
"""
def CheckChange(input_api, output_api):
- """Checks that actions.xml is up to date and pretty-printed."""
+ """Checks that rappor.xml is pretty-printed and well-formatted."""
for f in input_api.AffectedTextFiles():
p = f.AbsoluteLocalPath()
- if (input_api.basename(p) == 'actions.xml'
+ if (input_api.basename(p) == 'rappor.xml'
and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()):
cwd = input_api.os_path.dirname(p)
exit_code = input_api.subprocess.call(
- ['python', 'extract_actions.py', '--presubmit'], cwd=cwd)
+ ['python', 'pretty_print.py', '--presubmit'], cwd=cwd)
if exit_code != 0:
return [output_api.PresubmitError(
- 'actions.xml is not up to date or is not formatted correctly; '
- 'run extract_actions.py to fix')]
+ 'rappor.xml is not formatted correctly; run pretty_print.py '
+ 'to fix')]
return []
« no previous file with comments | « tools/metrics/rappor/OWNERS ('k') | tools/metrics/rappor/pretty_print.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698