Issue 925743002: Revert of Add test_runner hook to dump drag image.

Issue 925743002: Revert of Add test_runner hook to dump drag image. (Closed)

Created:
5 years, 10 months ago by tkent

Modified:
5 years, 10 months ago

Reviewers:
jackhou1, Justin Novosad

CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Add test_runner hook to dump drag image. (patchset #3 id:40001 of https://codereview.chromium.org/904833004/) Reason for revert: Caused pixel test flakiness. Original issue's description: > Add test_runner hook to dump drag image. > > This is used by: > https://codereview.chromium.org/886323005/ > > BUG=451759 > > Committed: https://crrev.com/3726d659908604350bc03ef02d1ccc5cdc097dd5 > Cr-Commit-Position: refs/heads/master@{#315915} TBR=junov@chromium.org,jackhou@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451759 Committed: https://crrev.com/29881876aff6c4639ac9378a2911be87b73c8a0a Cr-Commit-Position: refs/heads/master@{#316136}

Patch Set 1 #

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -39 lines)			Patch
M	content/shell/renderer/test_runner/test_runner.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	content/shell/renderer/test_runner/test_runner.cc	View	6 chunks	+0 lines, -17 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_proxy.h	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_proxy.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tkent

Created Revert of Add test_runner hook to dump drag image.

5 years, 10 months ago (2015-02-13 02:30:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925743002/1

5 years, 10 months ago (2015-02-13 02:32:06 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/29881876aff6c4639ac9378a2911be87b73c8a0a Cr-Commit-Position: refs/heads/master@{#316136}

5 years, 10 months ago (2015-02-13 02:34:25 UTC) #4

jackhou1

5 years, 10 months ago (2015-02-13 03:03:48 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/919273002/ by jackhou@chromium.org.

The reason for reverting is: Reverting this breaks the blink side CL that
depended on the new test_runner hook: https://codereview.chromium.org/886323005/
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/44149

Fix is here:
https://codereview.chromium.org/918313003/
I think it was failing CQ for unrelated reasons, so reverting this..

Expand Messages | Collapse Messages