Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 925723002: update code completion suggestion relevance based on common usage (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: add support for field/getter/setter relevance Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index 2c5f52873f323b64f04974193dd407eae433f583..e1ef9fc5e492ea41ae6162a1d31db7d4d35e4487 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -158,7 +158,7 @@ class CompletionDomainHandler implements RequestHandler {
/**
* Process a `completion.getSuggestions` request.
*/
- Response processRequest(Request request) {
+ Response processRequest(Request request, [CompletionManager manager]) {
performance = new CompletionPerformance();
// extract params
CompletionGetSuggestionsParams params =
@@ -168,7 +168,9 @@ class CompletionDomainHandler implements RequestHandler {
AnalysisContext context = server.getAnalysisContext(params.file);
Source source = server.getSource(params.file);
recordRequest(performance, context, source, params.offset);
- CompletionManager manager = completionManagerFor(context, source);
+ if (manager == null) {
+ manager = completionManagerFor(context, source);
+ }
CompletionRequest completionRequest =
new CompletionRequest(params.offset, performance);
int notificationCount = 0;
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698