Add profiling for FinishConfigureDataTypesOnFrontendLoop (sync).

Add profiling for FinishConfigureDataTypesOnFrontendLoop (sync).

BUG=458406
Committed: https://crrev.com/3aed7b0d4744cb3edfa39c291deb7eafe40c8982
Cr-Commit-Position: refs/heads/master@{#316877}

[erikchen, 2015-02-13 03:12:59]

erikchen@chromium.org changed reviewers:
+ vadimt@chromium.org

[erikchen, 2015-02-13 03:12:59]

vadimt: Please review.

[vadimt, 2015-02-13 15:22:57]

https://codereview.chromium.org/925673003/diff/20001/chrome/browser/sync/glue...
File chrome/browser/sync/glue/sync_backend_host_impl.cc (right):

https://codereview.chromium.org/925673003/diff/20001/chrome/browser/sync/glue...
chrome/browser/sync/glue/sync_backend_host_impl.cc:615: "458406
SyncBackendHostImpl::"
You can't split this string into 2 lines. Our source parser doesn't
understand this. Please shorten the string.

https://codereview.chromium.org/925673003/diff/20001/chrome/browser/sync/glue...
chrome/browser/sync/glue/sync_backend_host_impl.cc:630:
"FinishConfigureDataTypesOnFrontendLoop::ReadyTask"));
same

[erikchen, 2015-02-13 23:28:40]

vadimt: PTAL

https://codereview.chromium.org/925673003/diff/20001/chrome/browser/sync/glue...
File chrome/browser/sync/glue/sync_backend_host_impl.cc (right):

https://codereview.chromium.org/925673003/diff/20001/chrome/browser/sync/glue...
chrome/browser/sync/glue/sync_backend_host_impl.cc:615: "458406
SyncBackendHostImpl::"
On 2015/02/13 15:22:57, vadimt wrote:
> You can't split this string into 2 lines. Our source parser doesn't
> understand this. Please shorten the string.

Done.

https://codereview.chromium.org/925673003/diff/20001/chrome/browser/sync/glue...
chrome/browser/sync/glue/sync_backend_host_impl.cc:630:
"FinishConfigureDataTypesOnFrontendLoop::ReadyTask"));
On 2015/02/13 15:22:57, vadimt wrote:
> same

Done.

[vadimt, 2015-02-14 00:08:25]

lgtm

[erikchen, 2015-02-14 00:57:34]

erikchen@chromium.org changed reviewers:
+ stanisc@chromium.org

[erikchen, 2015-02-14 00:57:35]

stanisc: Looking for an OWNER review.

[stanisc, 2015-02-17 19:25:29]

lgtm

https://codereview.chromium.org/925673003/diff/40001/components/sync_driver/d...
File components/sync_driver/data_type_manager_impl.cc (right):

https://codereview.chromium.org/925673003/diff/40001/components/sync_driver/d...
components/sync_driver/data_type_manager_impl.cc:369: "458406
DataTypeManagerImpl::DownloadReady::NeedsReconfigure"));
Would it make sense to define a scope for each of these nested scoped trackers.
As I understand each of them will measure time until the end of DownloadReady.

https://codereview.chromium.org/925673003/diff/40001/components/sync_driver/d...
components/sync_driver/data_type_manager_impl.cc:424: StartNextAssociation();
I suspect most of the time is spent here. Also take a look at
Sync.*AssociationTime histograms.

[erikchen, 2015-02-18 18:57:15]

https://codereview.chromium.org/925673003/diff/40001/components/sync_driver/d...
File components/sync_driver/data_type_manager_impl.cc (right):

https://codereview.chromium.org/925673003/diff/40001/components/sync_driver/d...
components/sync_driver/data_type_manager_impl.cc:369: "458406
DataTypeManagerImpl::DownloadReady::NeedsReconfigure"));
On 2015/02/17 19:25:29, stanisc wrote:
> Would it make sense to define a scope for each of these nested scoped
trackers.
> As I understand each of them will measure time until the end of DownloadReady.

Each ScopedTracker automatically subtracts out the time consumed by more newly
constructed ScopedTrackers.

[erikchen, 2015-02-18 18:57:20]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-18 18:58:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/925673003/40001

[commit-bot: I haz the power, 2015-02-18 19:54:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-18 19:55:28]

Patchset 3 (id:??) landed as
https://crrev.com/3aed7b0d4744cb3edfa39c291deb7eafe40c8982
Cr-Commit-Position: refs/heads/master@{#316877}