Refactor the loading tracking logic in WebContentsImpl.

content/browser/frame_host/render_frame_host_impl.h

Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index ca442d27367f9a9f528b4d49454b85457810d156..99a8c9cc583b1c8657f4feccb190a6637e50c270 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -94,6 +94,13 @@ class CONTENT_EXPORT RenderFrameHostImpl
     : public RenderFrameHost,
       public BrowserAccessibilityDelegate {
  public:
+  // These values indicate the loading progress status. The minimum progress
+  // value matches what Blink's ProgressTracker has traditionally used for a
+  // minimum progress value.

[nasko, 2015/02/26 23:30:33]

If we plan to hide these values internally in the future, which I think we
should, it is good to put a TODO mentioning it.

[Fabrice (no longer in Chrome), 2015/02/27 17:45:25]

Acknowledged.

+  static const double kLoadingProgressNotStarted;
+  static const double kLoadingProgressMinimum;
+  static const double kLoadingProgressDone;
+
   // Keeps track of the state of the RenderFrameHostImpl, particularly with
   // respect to swap out.
   enum RenderFrameHostImplState {
@@ -203,6 +210,16 @@ class CONTENT_EXPORT RenderFrameHostImpl
   RenderFrameHostDelegate* delegate() { return delegate_; }
   FrameTreeNode* frame_tree_node() { return frame_tree_node_; }
 
+  void set_is_loading(bool is_loading) {
+    is_loading_ = is_loading;
+  }
+  bool is_loading() const { return is_loading_; }
+
+  void set_loading_progress(double loading_progress) {
+    loading_progress_ = loading_progress;
+  }
+  double loading_progress() const { return loading_progress_; }
+
   // This returns the RenderFrameHost's owned RenderWidgetHost if it has one,
   // or else it returns nullptr.
   // If the RenderFrameHost is the page's main frame, this returns instead a
@@ -664,6 +681,13 @@ class CONTENT_EXPORT RenderFrameHostImpl
   // PlzNavigate: all navigations require a beforeUnload ACK.
   bool unload_ack_is_for_navigation_;
 
+  // Boolean value indicating whether this RFH is in the process of loading a

[nasko, 2015/02/26 23:30:33]

Let's drop the "Boolean" part of the comment, it is obvious what the type is
from the next line. Same for the next one too.

[Fabrice (no longer in Chrome), 2015/02/27 17:45:25]

Acknowledged.

+  // document or not.
+  bool is_loading_;
+
+  // Double value representing this RFH's loading progress (from 0 to 1).
+  double loading_progress_;
+
   // Used to swap out or shut down this RFH when the unload event is taking too
   // long to execute, depending on the number of active frames in the
   // SiteInstance.