Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: content/browser/frame_host/frame_tree_node.h

Issue 925623002: Refactor the loading tracking logic in WebContentsImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree_node.h
diff --git a/content/browser/frame_host/frame_tree_node.h b/content/browser/frame_host/frame_tree_node.h
index 5d0a34bd366fd3875a632891acc18ac624c64080..c896bb63a042a40f6d44d88afb69fbfb6ba3a5f7 100644
--- a/content/browser/frame_host/frame_tree_node.h
+++ b/content/browser/frame_host/frame_tree_node.h
@@ -112,6 +112,11 @@ class CONTENT_EXPORT FrameTreeNode {
return is_loading_;
}
+ void set_loading_progress(double loading_progress) {
+ loading_progress_ = loading_progress;
+ }
+ double get_loading_progress() const { return loading_progress_; }
clamy 2015/02/13 12:13:43 s/get_loading_progress()/loading_progress() nit:
Fabrice (no longer in Chrome) 2015/02/13 18:04:24 Done.
clamy 2015/02/16 14:20:59 I don't see the modification to the accessor name
Fabrice (no longer in Chrome) 2015/02/20 12:58:58 Done.
+
RenderFrameHostImpl* current_frame_host() const {
return render_manager_.current_frame_host();
}
@@ -167,6 +172,9 @@ class CONTENT_EXPORT FrameTreeNode {
// RenderFrameHost or using a counter to balance the events out.
bool is_loading_;
carlosk 2015/02/13 15:05:41 Does the tracking of the loading progress happens
Fabrice (no longer in Chrome) 2015/02/13 18:04:24 This sounded good until I actually tried it and it
+ // Double value representing the frame's completion progress (from 0 to 1).
+ double loading_progress_;
+
DISALLOW_COPY_AND_ASSIGN(FrameTreeNode);
};
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.h » ('j') | content/browser/web_contents/web_contents_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698