Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: content/browser/frame_host/frame_tree_node.cc

Issue 925623002: Refactor the loading tracking logic in WebContentsImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WIP (Fix tests) Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_tree_node.h" 5 #include "content/browser/frame_host/frame_tree_node.h"
6 6
7 #include <queue> 7 #include <queue>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
11 #include "content/browser/frame_host/frame_tree.h" 11 #include "content/browser/frame_host/frame_tree.h"
12 #include "content/browser/frame_host/navigator.h" 12 #include "content/browser/frame_host/navigator.h"
13 #include "content/browser/frame_host/render_frame_host_impl.h" 13 #include "content/browser/frame_host/render_frame_host_impl.h"
14 #include "content/browser/renderer_host/render_view_host_impl.h" 14 #include "content/browser/renderer_host/render_view_host_impl.h"
15 #include "content/public/common/content_switches.h" 15 #include "content/public/common/content_switches.h"
16 16
17 namespace content { 17 namespace content {
18 18
19 double FrameTreeNode::kNotStartedLoadingProgress = 0.0;
Charlie Reis 2015/02/20 23:42:12 const double
Fabrice (no longer in Chrome) 2015/02/23 20:02:06 Done.
20 double FrameTreeNode::kMinimumLoadingProgress = 0.1;
21 double FrameTreeNode::kDoneLoadingProgress = 1.0;
19 int64 FrameTreeNode::next_frame_tree_node_id_ = 1; 22 int64 FrameTreeNode::next_frame_tree_node_id_ = 1;
20 23
21 FrameTreeNode::FrameTreeNode(FrameTree* frame_tree, 24 FrameTreeNode::FrameTreeNode(FrameTree* frame_tree,
22 Navigator* navigator, 25 Navigator* navigator,
23 RenderFrameHostDelegate* render_frame_delegate, 26 RenderFrameHostDelegate* render_frame_delegate,
24 RenderViewHostDelegate* render_view_delegate, 27 RenderViewHostDelegate* render_view_delegate,
25 RenderWidgetHostDelegate* render_widget_delegate, 28 RenderWidgetHostDelegate* render_widget_delegate,
26 RenderFrameHostManager::Delegate* manager_delegate, 29 RenderFrameHostManager::Delegate* manager_delegate,
27 const std::string& name) 30 const std::string& name)
28 : frame_tree_(frame_tree), 31 : frame_tree_(frame_tree),
29 navigator_(navigator), 32 navigator_(navigator),
30 render_manager_(this, 33 render_manager_(this,
31 render_frame_delegate, 34 render_frame_delegate,
32 render_view_delegate, 35 render_view_delegate,
33 render_widget_delegate, 36 render_widget_delegate,
34 manager_delegate), 37 manager_delegate),
35 frame_tree_node_id_(next_frame_tree_node_id_++), 38 frame_tree_node_id_(next_frame_tree_node_id_++),
36 parent_(NULL), 39 parent_(NULL),
37 replication_state_(name), 40 replication_state_(name),
38 is_loading_(false) { 41 is_loading_(false),
42 loading_progress_(kNotStartedLoadingProgress) {
39 } 43 }
40 44
41 FrameTreeNode::~FrameTreeNode() { 45 FrameTreeNode::~FrameTreeNode() {
42 if (base::CommandLine::ForCurrentProcess()->HasSwitch( 46 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
43 switches::kEnableBrowserSideNavigation)) { 47 switches::kEnableBrowserSideNavigation)) {
44 navigator_->CancelNavigation(this); 48 navigator_->CancelNavigation(this);
45 } 49 }
46 } 50 }
47 51
48 bool FrameTreeNode::IsMainFrame() const { 52 bool FrameTreeNode::IsMainFrame() const {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 113
110 for (FrameTreeNode* node = parent(); node; node = node->parent()) { 114 for (FrameTreeNode* node = parent(); node; node = node->parent()) {
111 if (node == other) 115 if (node == other)
112 return true; 116 return true;
113 } 117 }
114 118
115 return false; 119 return false;
116 } 120 }
117 121
118 } // namespace content 122 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698