Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Issue 925603004: Don't DCHECK that the runloop has been Run on iOS shutdown (Closed)

Created:
5 years, 10 months ago by stuartmorgan
Modified:
5 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't DCHECK that the runloop has been Run on iOS shutdown This resolves minor drift in this file from implementing the shutdown flow on iOS (for the rare cases when the app is told it is terminating). BUG=None Committed: https://crrev.com/23fddbca3e657e69ca0e6718d4a9be2c34821242 Cr-Commit-Position: refs/heads/master@{#316463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M base/message_loop/message_loop.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
stuartmorgan
5 years, 10 months ago (2015-02-13 09:30:18 UTC) #2
Mark Mentovai
LGTM
5 years, 10 months ago (2015-02-13 13:47:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925603004/1
5 years, 10 months ago (2015-02-14 15:13:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/59384)
5 years, 10 months ago (2015-02-14 15:23:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925603004/1
5 years, 10 months ago (2015-02-14 21:48:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25428)
5 years, 10 months ago (2015-02-14 23:10:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925603004/1
5 years, 10 months ago (2015-02-15 10:55:20 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25498)
5 years, 10 months ago (2015-02-15 12:09:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925603004/1
5 years, 10 months ago (2015-02-16 12:16:35 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 12:57:22 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 12:58:35 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23fddbca3e657e69ca0e6718d4a9be2c34821242
Cr-Commit-Position: refs/heads/master@{#316463}

Powered by Google App Engine
This is Rietveld 408576698