Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: components/autofill/core/common/password_form.cc

Issue 925593006: Pass all info to account chooser infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@java_cpp_enum
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form.cc
diff --git a/components/autofill/core/common/password_form.cc b/components/autofill/core/common/password_form.cc
index 3ff8447a069f2dc5ad457b86b2b08a51e14333f7..8ce19f955c5ac80a6f0f01fc186a728122f0bdb1 100644
--- a/components/autofill/core/common/password_form.cc
+++ b/components/autofill/core/common/password_form.cc
@@ -9,6 +9,11 @@
#include "base/strings/utf_string_conversions.h"
#include "components/autofill/core/common/password_form.h"
+#if defined(OS_ANDROID)
+#include "base/android/jni_string.h"
+#include "jni/Credential_jni.h"
+#endif
+
namespace autofill {
PasswordForm::PasswordForm()
@@ -64,6 +69,23 @@ bool PasswordForm::operator!=(const PasswordForm& form) const {
return !operator==(form);
}
+#if defined(OS_ANDROID)
+base::android::ScopedJavaLocalRef<jobject> PasswordForm::createNativeCredential(
+ JNIEnv* env,
+ int type) {
+ return createNativeCredential(env, 0, type);
+}
+
+base::android::ScopedJavaLocalRef<jobject>
+PasswordForm::createNativeCredential(JNIEnv* env, int position, int type) {
+ return Java_Credential_createCredential(
+ env, base::android::ConvertUTF16ToJavaString(env, username_value).obj(),
+ base::android::ConvertUTF16ToJavaString(env, display_name).obj(),
+ base::android::ConvertUTF8ToJavaString(env, avatar_url.path()).obj(),
+ type, position);
+}
+#endif
+
std::ostream& operator<<(std::ostream& os, const PasswordForm& form) {
return os << "scheme: " << form.scheme
<< " signon_realm: " << form.signon_realm
@@ -97,4 +119,16 @@ std::ostream& operator<<(std::ostream& os, const PasswordForm& form) {
<< " skip_next_zero_click: " << form.skip_zero_click;
}
+#if defined(OS_ANDROID)
+base::android::ScopedJavaLocalRef<jobjectArray> CreateNativeCredentialArray(
+ JNIEnv* env,
+ size_t size) {
+ return Java_Credential_createCredentialArray(env, static_cast<int>(size));
+}
+
+bool RegisterCredential(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}
+#endif
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698