Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 925583004: Mac: Fix incorrect tab dragging window drawing. (Closed)

Created:
5 years, 10 months ago by Andre
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ThreePartImage
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix incorrect tab dragging window drawing. Tab dragging window doesn't draw correctly after https://crrev.com/900613003/ because BackgroundGradientView no longer calls cr_recursivelySetNeedsDisplay. Fixed by making TabView and BookmarkButton redraw itself when moved to another window. BUG=453996 Committed: https://crrev.com/70a38fbe28f6d9f038e7e81f40617d9bb5aaa1dc Cr-Commit-Position: refs/heads/master@{#316131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/background_gradient_view.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Andre
Robert, PTAL.
5 years, 10 months ago (2015-02-12 22:42:40 UTC) #2
Robert Sesek
lgtm
5 years, 10 months ago (2015-02-12 23:37:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925583004/1
5 years, 10 months ago (2015-02-13 01:56:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 02:18:09 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 02:18:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70a38fbe28f6d9f038e7e81f40617d9bb5aaa1dc
Cr-Commit-Position: refs/heads/master@{#316131}

Powered by Google App Engine
This is Rietveld 408576698