Supervised users: Slightly relax restrictions around extensions.

extensions/browser/management_policy.h

Index: extensions/browser/management_policy.h
diff --git a/extensions/browser/management_policy.h b/extensions/browser/management_policy.h
index 09b59b1c5e952c5218429311599e168a3c478fe5..61a062f7d58a5d7375a188d52cc296e4ee8bc92a 100644
--- a/extensions/browser/management_policy.h
+++ b/extensions/browser/management_policy.h
@@ -52,12 +52,18 @@ class ManagementPolicy {
 
     // Providers should return false if a user may not install the |extension|,
     // or load or run it if it has already been installed.
+    // TODO(treib,pam): The method name is misleading, since this applies to all
+    // extension installations, not just user-initiated ones. Fix either the

[benwells, 2015/02/25 03:23:32]

Please file a bug to cover all these todos as well.

[Marc Treib, 2015/02/25 09:48:55]

Done.

+    // name or the semantics.
     virtual bool UserMayLoad(const Extension* extension,
                              base::string16* error) const;
 
     // Providers should return false if a user may not enable, disable, or
     // uninstall the |extension|, or change its usage options (incognito
     // permission, file access, etc.).
+    // TODO(treib,pam): The method name is misleading, since this applies to all
+    // setting modifications, not just user-initiated ones. Fix either the
+    // name or the semantics.
     virtual bool UserMayModifySettings(const Extension* extension,
                                        base::string16* error) const;
 
@@ -98,16 +104,18 @@ class ManagementPolicy {
 
   // Returns true if the user is permitted to install, load, and run the given
   // extension. If not, |error| may be set to an appropriate message.
+  // TODO(treib,pam): Misleading name; see comment in Provider above.
   bool UserMayLoad(const Extension* extension, base::string16* error) const;
 
   // Returns true if the user is permitted to enable, disable, or uninstall the
   // given extension, or change the extension's usage options (incognito mode,
   // file access, etc.). If not, |error| may be set to an appropriate message.
+  // TODO(treib,pam): Misleading name; see comment in Provider above.
   bool UserMayModifySettings(const Extension* extension,
                              base::string16* error) const;
 
   // Returns true if the extension must remain enabled at all times (e.g. a
-  // compoment extension). In that case, |error| may be set to an appropriate
+  // component extension). In that case, |error| may be set to an appropriate
   // message.
   bool MustRemainEnabled(const Extension* extension,
                          base::string16* error) const;