Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: extensions/browser/management_policy.h

Issue 925563002: Supervised users: Slightly relax restrictions around extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_ext_install_disable
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/management_policy.h
diff --git a/extensions/browser/management_policy.h b/extensions/browser/management_policy.h
index 09b59b1c5e952c5218429311599e168a3c478fe5..3ae845edbffd034712059733fa2a1306ca95cbfb 100644
--- a/extensions/browser/management_policy.h
+++ b/extensions/browser/management_policy.h
@@ -52,12 +52,18 @@ class ManagementPolicy {
// Providers should return false if a user may not install the |extension|,
// or load or run it if it has already been installed.
+ // TODO(treib,pam): The method name is misleading, since this applies to all
+ // extension installations, not just user-initiated ones. Fix either the
+ // name or the semantics. crbug.com/461747
virtual bool UserMayLoad(const Extension* extension,
base::string16* error) const;
// Providers should return false if a user may not enable, disable, or
// uninstall the |extension|, or change its usage options (incognito
// permission, file access, etc.).
+ // TODO(treib,pam): The method name is misleading, since this applies to all
+ // setting modifications, not just user-initiated ones. Fix either the
+ // name or the semantics. crbug.com/461747
virtual bool UserMayModifySettings(const Extension* extension,
base::string16* error) const;
@@ -98,16 +104,18 @@ class ManagementPolicy {
// Returns true if the user is permitted to install, load, and run the given
// extension. If not, |error| may be set to an appropriate message.
+ // TODO(treib,pam): Misleading name; see comment in Provider. crbug.com/461747
bool UserMayLoad(const Extension* extension, base::string16* error) const;
// Returns true if the user is permitted to enable, disable, or uninstall the
// given extension, or change the extension's usage options (incognito mode,
// file access, etc.). If not, |error| may be set to an appropriate message.
+ // TODO(treib,pam): Misleading name; see comment in Provider. crbug.com/461747
bool UserMayModifySettings(const Extension* extension,
base::string16* error) const;
// Returns true if the extension must remain enabled at all times (e.g. a
- // compoment extension). In that case, |error| may be set to an appropriate
+ // component extension). In that case, |error| may be set to an appropriate
// message.
bool MustRemainEnabled(const Extension* extension,
base::string16* error) const;
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698