Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: chrome/browser/supervised_user/supervised_user_service.h

Issue 925563002: Supervised users: Slightly relax restrictions around extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_ext_install_disable
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_service.h
diff --git a/chrome/browser/supervised_user/supervised_user_service.h b/chrome/browser/supervised_user/supervised_user_service.h
index 8b16b444a0875752654da385048645ae6778b8d7..e4b77e1de89a92c64434519143f72138a55b2856 100644
--- a/chrome/browser/supervised_user/supervised_user_service.h
+++ b/chrome/browser/supervised_user/supervised_user_service.h
@@ -162,15 +162,6 @@ class SupervisedUserService : public KeyedService,
void AddPermissionRequestCreator(
scoped_ptr<PermissionRequestCreator> creator);
-#if defined(ENABLE_EXTENSIONS)
- // extensions::ManagementPolicy::Provider implementation:
- std::string GetDebugPolicyProviderName() const override;
- bool UserMayLoad(const extensions::Extension* extension,
- base::string16* error) const override;
- bool UserMayModifySettings(const extensions::Extension* extension,
- base::string16* error) const override;
-#endif
-
// SyncTypePreferenceProvider implementation:
syncer::ModelTypeSet GetPreferredDataTypes() const override;
@@ -192,6 +183,8 @@ class SupervisedUserService : public KeyedService,
ChangesIncludedSessionOnChangedSettings);
FRIEND_TEST_ALL_PREFIXES(SupervisedUserServiceTest,
ChangesSyncSessionStateOnChangedSettings);
+ FRIEND_TEST_ALL_PREFIXES(SupervisedUserServiceExtensionTest,
+ ExtensionManagementPolicyProvider);
// A bridge from the UI thread to the SupervisedUserURLFilters, one of which
// lives on the IO thread. This class mediates access to them and makes sure
@@ -259,11 +252,12 @@ class SupervisedUserService : public KeyedService,
void OnCustodianInfoChanged();
#if defined(ENABLE_EXTENSIONS)
- // Internal implementation for ExtensionManagementPolicy::Delegate methods.
- // If |error| is not NULL, it will be filled with an error message if the
- // requested extension action (install, modify status, etc.) is not permitted.
- bool ExtensionManagementPolicyImpl(const extensions::Extension* extension,
- base::string16* error) const;
+ // extensions::ManagementPolicy::Provider implementation:
+ std::string GetDebugPolicyProviderName() const override;
+ bool UserMayLoad(const extensions::Extension* extension,
+ base::string16* error) const override;
+ bool MustRemainInstalled(const extensions::Extension* extension,
+ base::string16* error) const override;
// Extensions helper to SetActive().
void SetExtensionsActive();
« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/supervised_user/supervised_user_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698