Supervised users: Slightly relax restrictions around extensions.

extensions/browser/management_policy.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_MANAGEMENT_POLICY_H_
 #define EXTENSIONS_BROWSER_MANAGEMENT_POLICY_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 34 matching lines @@
     Provider() {}
     virtual ~Provider() {}
 
     // A human-readable name for this provider, for use in debug messages.
     // Implementers should return an empty string in non-debug builds, to save
     // executable size.
     virtual std::string GetDebugPolicyProviderName() const = 0;
 
     // Providers should return false if a user may not install the |extension|,
     // or load or run it if it has already been installed.
+    // TODO(treib,pam): The method name is misleading, since this applies to all
+    // extension installations, not just user-initiated ones. Fix either the

[benwells, 2015/02/25 03:23:32]

Please file a bug to cover all these todos as well.

[Marc Treib, 2015/02/25 09:48:55]

Done.

+    // name or the semantics.
     virtual bool UserMayLoad(const Extension* extension,
                              base::string16* error) const;
 
     // Providers should return false if a user may not enable, disable, or
     // uninstall the |extension|, or change its usage options (incognito
     // permission, file access, etc.).
+    // TODO(treib,pam): The method name is misleading, since this applies to all
+    // setting modifications, not just user-initiated ones. Fix either the
+    // name or the semantics.
     virtual bool UserMayModifySettings(const Extension* extension,
                                        base::string16* error) const;
 
     // Providers should return true if the |extension| must always remain
     // enabled. This is distinct from UserMayModifySettings() in that the latter
     // also prohibits enabling the extension if it is currently disabled.
     // Providers implementing this method should also implement the others
     // above, if they wish to completely lock in an extension.
     virtual bool MustRemainEnabled(const Extension* extension,
                                    base::string16* error) const;
@@ skipping 20 matching lines @@
   // from the list of providers queried. Ownership of the provider remains with
   // the caller. Providers do not need to be unregistered on shutdown.
   void RegisterProvider(Provider* provider);
   void UnregisterProvider(Provider* provider);
 
   // Like RegisterProvider(), but registers multiple providers instead.
   void RegisterProviders(std::vector<Provider*> providers);
 
   // Returns true if the user is permitted to install, load, and run the given
   // extension. If not, |error| may be set to an appropriate message.
+  // TODO(treib,pam): Misleading name; see comment in Provider above.
   bool UserMayLoad(const Extension* extension, base::string16* error) const;
 
   // Returns true if the user is permitted to enable, disable, or uninstall the
   // given extension, or change the extension's usage options (incognito mode,
   // file access, etc.). If not, |error| may be set to an appropriate message.
+  // TODO(treib,pam): Misleading name; see comment in Provider above.
   bool UserMayModifySettings(const Extension* extension,
                              base::string16* error) const;
 
   // Returns true if the extension must remain enabled at all times (e.g. a
-  // compoment extension). In that case, |error| may be set to an appropriate
+  // component extension). In that case, |error| may be set to an appropriate
   // message.
   bool MustRemainEnabled(const Extension* extension,
                          base::string16* error) const;
 
   // Returns true immediately if any registered provider's MustRemainDisabled
   // function returns true.
   bool MustRemainDisabled(const Extension* extension,
                           Extension::DisableReason* reason,
                           base::string16* error) const;
 
@@ skipping 26 matching lines @@
                            base::string16* error) const;
 
   ProviderList providers_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagementPolicy);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_MANAGEMENT_POLICY_H_